Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

GCD function doens't work #94

Open
PaulZhu0122 opened this issue May 21, 2021 · 0 comments
Open

GCD function doens't work #94

PaulZhu0122 opened this issue May 21, 2021 · 0 comments
Assignees
@PaulZhu0122

Comments

@PaulZhu0122
Copy link

Describe the bug

In the scientific calculator module, after choosing GCD fuction and entering two integers, the calculator just displays GCD(num1, num2). It doesn't give the correct result.

Expected behavior

After entering two numbers, the greatest common divisor is expected to be displayed

To reproduce

  1. Open NCalc+ (Which is build from latest source code)
  2. Go to scientific calculator module
  3. Choose GCD function in advanced button
  4. Enter two positive integers
  5. Incorrect result has been displayed

Configuration

  • Android version 9
  • device MI 8 Lite

Screenshots

image
image
PAUL-Zf added a commit to PAUL-Zf/ncalc that referenced this issue May 22, 2021
@PAUL-Zf
Fix issue tranleduy2000#94: GCD function doens't work and realize GCD…
2779ebc 
… function
@PAUL-Zf PAUL-Zf mentioned this issue May 22, 2021
Merged
axkr pushed a commit that referenced this issue May 22, 2021
@PAUL-Zf
Fix issue #94: GCD function doens't work and realize GCD function (#100)
65c514d 
* Fix issue #84: Permutation result is not right

* Fix issue #84: Permutation result is not right

* Fix issue #94: GCD function doens't work and realize GCD function

* Fix issue #95: LCM function doesn't work and realize LCM function based on GCD function
axkr added a commit that referenced this issue May 22, 2021
@axkr
#94: GCD , LCM removed $$
866defd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PaulZhu0122 PaulZhu0122

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulZhu0122