-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karma, code coverage, cross-browser testing #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage ? 17.08%
=========================================
Files ? 6
Lines ? 357
Branches ? 0
=========================================
Hits ? 61
Misses ? 296
Partials ? 0
Continue to review full report at Codecov.
|
Hmm, you are now basically forcing the transform stream to be a polyfilled version. import('https://cdn.jsdelivr.net/npm/@transcend-io/conflux@2.0.2/src/write.js')
// Uncaught (in promise) TypeError: Failed to resolve module specifier "web-streams-polyfill/ponyfill". Relative references must start with either "/", "./", or "../". not happy with this changed, just tried to help @ibudisteanu a bit with his #64 |
Is this the same as #52? Regarding enabling |
Hmm, yes
I like buildless tools... we only got one problem to make browser import possible and that is to get rid of web-streams-polyfill npm module wish we could do something similar to streamsaver. Maybe we can do: const TransformStream = globalThis.TransformStream || globalThis.WebStreamsPolyfill?.TransformStream then npm folks can do the following if they want: const polyfill = require('web-streams-polyfill')
globalThis.WebStreamsPolyfill = polyfill
const ZipWriter = require('conflux/write.js') |
src