INT-B-20522 sit validation (#13720)

* cannot set SIT payment start/end dates prior to SIT Entry/Departure dates

* fixed error string

* fixed nil error

* updated error message and removed departure date check

* removed default error case

* properly checking if payment start date is at least a day after SIT entry date

* fix devseed

* updated error message to new PO specifications

pkg/handlers/primeapi/payment_request.go

@@ -127,7 +127,8 @@ func (h CreatePaymentRequestHandler) Handle(params paymentrequestop.CreatePaymen
 						zap.Any("payload", payload))
 					return paymentrequestop.NewCreatePaymentRequestBadRequest().WithPayload(payload), err
 				default:
-					if e.Error() == "cannot have payment date earlier than or equal to SIT Entry date" {
+					if e.Error() == "cannot have payment start date for additional days SIT earlier than or equal to SIT entry date" {
+
 						payload := payloads.ClientError(handlers.ConflictErrMessage, err.Error(), h.GetTraceIDFromRequest(params.HTTPRequest))
 
 						appCtx.Logger().Error("Payment Request",

pkg/services/payment_request/payment_request_creator.go

@@ -151,7 +151,7 @@ func (p *paymentRequestCreator) CreatePaymentRequest(appCtx appcontext.AppContex
 					}
 
 					if paymentServiceItem.MTOServiceItem.SITEntryDate != nil && !paymentDate.After(*paymentServiceItem.MTOServiceItem.SITEntryDate) {
-						return apperror.NewConflictError(paymentRequestArg.ID, "cannot have payment date earlier than or equal to SIT Entry date")
+						return apperror.NewConflictError(paymentRequestArg.ID, "cannot have payment start date for additional days SIT earlier than or equal to SIT entry date")
 					}
 				}