-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 20290 int add amount reimbursement #13166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-mettler
requested review from
MInthavongsay,
antgmann,
ajlusk and
CoryKleinjanCACI
June 28, 2024 21:27
r-mettler
added
Scrummy Bears
Scrum Team H
INTEGRATION
Slated for Integration Testing
labels
Jun 28, 2024
CoryKleinjanCACI
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and test steps pass.
Bumps [github.com/gorilla/csrf](https://github.com/gorilla/csrf) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/gorilla/csrf/releases) - [Commits](gorilla/csrf@v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: github.com/gorilla/csrf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…com/gorilla/csrf-1.7.2 Bump github.com/gorilla/csrf from 1.7.1 to 1.7.2
Bumps [github.com/jarcoal/httpmock](https://github.com/jarcoal/httpmock) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/jarcoal/httpmock/releases) - [Commits](jarcoal/httpmock@v1.3.0...v1.3.1) --- updated-dependencies: - dependency-name: github.com/jarcoal/httpmock dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…com/jarcoal/httpmock-1.3.1 Bump github.com/jarcoal/httpmock from 1.3.0 to 1.3.1
ajlusk
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-20290
Summary
This story adds Actual SIT Reimbursement field to the Review Documents page for storage moving expenses. The value should be the smaller of the Government SIT Cost and the Amount Requested. The Actual SIT Reimbursement amount will adjust as SIT Cost and Amount Requested are updated. The Actual SIT Reimbursement amount is saved into a new DB column in the moving_expenses table and will be loaded into the SSW for shipments that have a storage type moving expense. The SSW was also updated to use the Actual SIT Reimbursement amount for PPM shipments with storage moving expense in the Member-paid SIT field.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots