B 20290 int add amount reimbursement

[r-mettler]

B-20290

Summary

This story adds Actual SIT Reimbursement field to the Review Documents page for storage moving expenses. The value should be the smaller of the Government SIT Cost and the Amount Requested. The Actual SIT Reimbursement amount will adjust as SIT Cost and Amount Requested are updated. The Actual SIT Reimbursement amount is saved into a new DB column in the moving_expenses table and will be loaded into the SSW for shipments that have a storage type moving expense. The SSW was also updated to use the Actual SIT Reimbursement amount for PPM shipments with storage moving expense in the Member-paid SIT field.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Login as a Customer
2. Create a PPM shipment and make sure you enter Yes when asked if you plan to use storage
3. Submit the shipment
4. Login as a Service Counselor
5. Approve the shipment
6. Login as the customer
7. Upload PPM documents and fill out the first few pages
8. Make sure you add a Storage type moving expense to the shipment
9. Submit the documents
10. Login as the Service Counselor
11. Go to the PPM Closeout Queue select the shipment
12. Click on the Review Documents button
13. You should see the Actual SIT Reimbursement which is the lower of the Government SIT Cost and Amount Requested
14. Adjust the location or other SIT items so the cost updates and also adjust Amount Requested verify Actual SIT Reimbursement is the lower of the two amounts
15. Accept and approve the documents
16. Click the download link for the Payment Packet
17. Look at the Member-paid SIT field and verify the amount is the same as was shown on the Actual SIT Reimbursement displayed on the Review Documents page

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[CoryKleinjanCACI]

Code looks good and test steps pass.

[ajlusk]

Functions as described. Tests passing. No notes from code review.