Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B 20915 #13540

Merged
merged 6 commits into from
Aug 22, 2024
Merged

B 20915 #13540

merged 6 commits into from
Aug 22, 2024

Conversation

deandreJones
Copy link
Contributor

@deandreJones deandreJones added Mountain Movers Movin' Mountains 1 Sprint at a time MAIN labels Aug 22, 2024
@deandreJones deandreJones requested review from a team and danieljordan-caci August 22, 2024 14:18
@deandreJones deandreJones requested a review from a team as a code owner August 22, 2024 14:18
@danieljordan-caci
Copy link
Contributor

Any reason why your file counts are so different?

I see two different INT PRs that changed ~1,500 lines of code, but this one is changing 4k+?

@deandreJones
Copy link
Contributor Author

Any reason why your file counts are so different?

I see two different INT PRs that changed ~1,500 lines of code, but this one is changing 4k+?

confused on what you are saying?
since its db migration- each int pr would require a new migration file

traskowskycaci
traskowskycaci reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a int PR/branch that contains your 20240816200315_update_pws_violations_pt2.up.sql migration to confirm that made it? I'm seeing the part 1 and part 2 for the int PRs

@deandreJones
Copy link
Contributor Author

Is there a int PR/branch that contains your 20240816200315_update_pws_violations_pt2.up.sql migration to confirm that made it? I'm seeing the part 1 and part 2 for the int PRs

072980d

not sure what happened to the PR, but its in integration

traskowskycaci
traskowskycaci approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, all of this matches up in integrationTesting!

danieljordan-caci
danieljordan-caci approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maria beat me to it. Commits match up - send it.

@deandreJones deandreJones merged commit 9d8c958 into main Aug 22, 2024
41 checks passed
@deandreJones deandreJones deleted the B-20915 branch August 22, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljordan-caci danieljordan-caci danieljordan-caci approved these changes

@traskowskycaci traskowskycaci traskowskycaci approved these changes

@TevinAdams TevinAdams Awaiting requested review from TevinAdams TevinAdams was automatically assigned from transcom/mountain-movers

@cameroncaci cameroncaci Awaiting requested review from cameroncaci cameroncaci was automatically assigned from transcom/mountain-movers

Assignees
No one assigned
Labels
MAIN Mountain Movers Movin' Mountains 1 Sprint at a time
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deandreJones @danieljordan-caci @traskowskycaci