-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN - B -19815- Office date validation/ alert - HHG, NTS, NTSR #13561
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has all changes from INT for 19815 and 19813
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once e7c7693 is in I will merge this.
…mymove into B-19815-Office-Date-Validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only difference is the test fix, only fail is flaky. LGTM
Cherry picked in the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all changes good now
B-19815
INT PR
B-19813
INT PR
Summary
MAIN
This PR adds date validation for HHG, NTS and NTSR for requested pickup and/or delivery date selection for the shipment new/edit shipment views for SC and TOO roles. It's a follow up to PR-B -19813. An inline alert message will appear upon date selection from date picker. An alert message will appear on page load and on date selection. Message will be customized to respective date label. Alert will notify user if date selected is on weekend and/or holiday(federal holidays). For now implementation will assume date context is in the United States. For example, July 4th is a holiday and Sat/Sunday are considered weekend days.
Note: This PR contains code from PR-B -19813
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Screenshots