B-19191: Email Template not locating all duty location names #13579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Duty Location ID is nil on the Orders, we just return the name of the Origin Address -also added test
WeatherfordAaron
added
ByteSize M&Ms
| @@ -72,7 +72,8 @@ func (m MoveSubmitted) emails(appCtx appcontext.AppContext) ([]emailContent, err | |||
| if originDSTransportInfo != nil { | |||
| originDutyLocationName = &originDSTransportInfo.Name | |||
| originDutyLocationPhoneLine = &originDSTransportInfo.PhoneLine | |||
|
|
|||
| } else if originDutyLocation != nil { | |||
| originDutyLocationName = &originDutyLocation.Name | |||
There was a problem hiding this comment.
Previously, if it didn't return a duty location ID, it would just not include the origin info in the email. Since that information is held in a different location, I figured we could just grab it from there in the event that the duty location did not have an ID
| suite.NotEmpty(email.textBody) | ||
| suite.Contains(email.textBody, move.Orders.OriginDutyLocation.Name) | ||
| } | ||
|
|
There was a problem hiding this comment.
The above function follows the same process as some of the other tests for this kind of email, except it modifies the OriginDutyLocationID to be nil so that it will trigger the 'else-if' section I added
| @@ -328,7 +328,7 @@ describe('ServicesCounselingEditShipmentDetails component', () => { | |||
| expect( | |||
| screen.getByText('Something went wrong, and your changes were not saved. Please try again.'), | |||
| ).toBeVisible(); | |||
| }); | |||
| }, 10000); | |||
There was a problem hiding this comment.
Added a timeout on this assertion to mitigate the flakiness of this test since it failed quite a few times as I was trying to get the CircleCI tests to pass
…ating-all-duty-location-names
JamesHawks224
approved these changes
Aug 29, 2024
WeatherfordAaron
deleted the
B-19191-Email-Template-not-locating-all-duty-location-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket B-19191
Steps to test
Note: make sure you set the Customer's personal email to an address you can check