Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN-B-20941-ssw-duplicate-state-zip #13602

Merged
merged 15 commits into from
Sep 4, 2024
Merged

Conversation

MInthavongsay
Copy link
Contributor

B-20941

INT PR

Summary

MAIN

This PR fixes a small issue in the SSW PDF for AOA/Payment download where Authorized Origin field was displaying duplicate state and zip.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Login as customer to create and submit move with PPM. Make sure to click YES for "Would you like to request an advance on your incentive?"
  2. Login as a SC and fill in all required fields and click submit move details. Page will refresh containing AOA download link. Download and verify Authorized Origin field does not contain duplicate state/zip.
  3. Login as customer and click upload PPM Documents and complete/submit process of providing documents for review.
  4. Login as SC and review documents. Approve/Reject and confirm/submit. Page will refresh containing Payment Download link. Download and verify Authorized Origin field does not contain duplicate state/zip.
  5. Login as customer and click Payment Download and verify Authorized Origin field does not contain duplicate state/zip.
Screenshot 2024-08-22 at 9 31 19 AM

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

…location.name. updated factory create duty location method to incude state and zip in location name to make it consistent with real data.
Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches INT

Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@r-mettler r-mettler merged commit 6ef77c0 into main Sep 4, 2024
41 checks passed
@r-mettler r-mettler deleted the B-20941-SSW-Duplicate-State-Zip branch September 4, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants