Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nts loa and SIT flaky fix int #13613

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Nts loa and SIT flaky fix int #13613

merged 4 commits into from
Sep 3, 2024

Conversation

cameroncaci
Copy link
Contributor

@cameroncaci cameroncaci commented Sep 3, 2024 •
edited
Loading

Lines of Accounting E2E

Fixes flaky formatting causing the following test to fail
https://app.circleci.com/pipelines/github/transcom/mymove/74644/workflows/333fc39d-183e-447d-b592-802ddb69953b/jobs/1315694/tests#failed-test-0

This is due to DateTimeFormat not sharing the same format as MomentJS which we use in our src code. MomentJS is not used within Playwright at this time due to additional setup required to get it compatible with the TypeScript check enforced through our e2e tests.

Previously, this would pass in August but the formatting fails for September.

SIT E2E

Fixed flaky SIT tests https://app.circleci.com/pipelines/github/transcom/mymove/74655/workflows/3b2861e7-f276-4be6-b40d-6911b9caf8d5/jobs/1315834

Due to month calculation diffs

Dashboard view
Screenshot 2024-09-03 at 10 46 44 AM

The day after today thru authorized end date (Today is already counted in the current SIT)
image

Aug 4 - Today
image

July 5 - Aug 4
image

@cameroncaci cameroncaci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Sep 3, 2024
@cameroncaci cameroncaci requested a review from a team September 3, 2024 13:39
@cameroncaci cameroncaci self-assigned this Sep 3, 2024
@cameroncaci cameroncaci requested a review from a team as a code owner September 3, 2024 13:39
@cameroncaci cameroncaci changed the base branch from main to integrationTesting September 3, 2024 13:39
@traskowskycaci
Copy link
Contributor

Failing SSW server tests should be fixed in this PR: https://github.com/transcom/mymove/pull/13574/files

@cameroncaci cameroncaci changed the title Nts loa flaky fix int Nts loa and SIT flaky fix int Sep 3, 2024
@cameroncaci cameroncaci marked this pull request as draft September 3, 2024 15:29
@cameroncaci cameroncaci marked this pull request as ready for review September 3, 2024 15:37
@cameroncaci
Copy link
Contributor Author

Found flaky SIT tests due to month issues - resolved

@cameroncaci cameroncaci mentioned this pull request Sep 3, 2024
Merged
@deandreJones
Copy link
Contributor

looks like the days are still off in the server_test fail

@deandreJones
Copy link
Contributor

looks like the days are still off in the server_test fail

actually the fail is related to SSW

do we need to consider how we count days for all testing purposes?

@traskowskycaci
Copy link
Contributor

looks like the days are still off in the server_test fail

actually the fail is related to SSW

do we need to consider how we count days for all testing purposes?

Anthony caught this test failure, explained at the bottom of this PR: #13594

Fix is in this PR, not in int yet: #13574

@cameroncaci
Copy link
Contributor Author

cameroncaci commented Sep 3, 2024 •
edited
Loading

do we need to consider how we count days for all testing purposes?

Since the SIT dashboard is populated entirely by the backend, I have some checks to make sure it works properly. For example, this snippet for the authorized end date double checks the backend calculation on the frontend https://github.com/transcom/mymove/pull/13613/files#diff-d804e95767522788e9051063bb6ce933aeea6e2d61dc03162a91ebfa190c8070R74-R79

danieljordan-caci
danieljordan-caci approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it!

@cameroncaci cameroncaci merged commit 09b8e7f into integrationTesting Sep 3, 2024
28 of 29 checks passed
@cameroncaci cameroncaci deleted the nts-loa-flaky-fix-int branch September 3, 2024 17:31
This was referenced Sep 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljordan-caci danieljordan-caci danieljordan-caci approved these changes

@TevinAdams TevinAdams TevinAdams approved these changes

@traskowskycaci traskowskycaci traskowskycaci approved these changes

@deandreJones deandreJones Awaiting requested review from deandreJones

Assignees

@cameroncaci cameroncaci

Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cameroncaci @traskowskycaci @deandreJones @danieljordan-caci @TevinAdams