-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 20942 ssw label #13617
Merged
Merged
B 20942 ssw label #13617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgmann
requested review from
MInthavongsay,
r-mettler,
ajlusk and
CoryKleinjanCACI
September 3, 2024 17:14
r-mettler
reviewed
Sep 4, 2024
r-mettler
reviewed
Sep 4, 2024
pkg/services/shipment_summary_worksheet/shipment_summary_worksheet.go
Outdated
Show resolved
Hide resolved
r-mettler
approved these changes
Sep 4, 2024
CoryKleinjanCACI
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-20942
Int PR
Warning
Per INT PR: Commit 2b95b2f and b80d672 is made directly on the int branch to resolve merge conflicts between other SSW features in the server tests only. This solution to the merge conflicts should be made the same way when moving the feature to main. Commit 2b95b2f and b80d672 have their changes already present in main at time of writing, so pulling in these commits is not necessary.
Summary
This PR adjusts the SSW PDF Template to change the "Actual Move Date" field to instead read "Pick-up date". It also additionally ensures that for a Payment Packet, the actual pick-up date (actual move date is the same value) is used. But, for an AOA packet, the expected departure date is used instead.
Due to git not being able to merge PDF files, this will have to be downstream of the latest template change, B-20939
Further, some code was refactored to remove an erroneous loop that was running for only one ppm shipment in a FormatAllShipments function. This was instead combined with the formatCurrentShipment function, and renamed formatShipment. These changes make things more clear, and it helps clean things up for an upcoming feature supporting multiple shipment information in a single SSW.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Backend
Screenshots