B 20653 mobile home shipment card

pkg/services/move/move_router.go

@@ -207,8 +207,10 @@ func (router moveRouter) sendToServiceCounselor(appCtx appcontext.AppContext, mo
 				return apperror.NewInvalidInputError(move.MTOShipments[i].PPMShipment.ID, err, verrs, msg)
 			}
 		}
-		// update status for boat shipment
-		if move.MTOShipments[i].ShipmentType == models.MTOShipmentTypeBoatHaulAway || move.MTOShipments[i].ShipmentType == models.MTOShipmentTypeBoatTowAway {
+		// update status for boat or mobile home shipment
+		if move.MTOShipments[i].ShipmentType == models.MTOShipmentTypeBoatHaulAway ||
+			move.MTOShipments[i].ShipmentType == models.MTOShipmentTypeBoatTowAway ||
+			move.MTOShipments[i].ShipmentType == models.MTOShipmentTypeMobileHome {
 			move.MTOShipments[i].Status = models.MTOShipmentStatusSubmitted
 
 			if verrs, err := appCtx.DB().ValidateAndUpdate(&move.MTOShipments[i]); verrs.HasAny() || err != nil {

playwright/tests/my/mymove/mobileHome.spec.js

@@ -0,0 +1,142 @@
+// @ts-check
+import { test, expect } from '../../utils/my/customerTest';
+
+const multiMoveEnabled = process.env.FEATURE_FLAG_MULTI_MOVE;
+
+test.describe('Mobile Home shipment', () => {
+  test.skip(multiMoveEnabled === 'true', 'Skip if MultiMove workflow is enabled.');
+
+  test('A customer can create a Mobile Home shipment', async ({ page, customerPage }) => {
+    // Generate a new onboarded user with orders and log in
+    const move = await customerPage.testHarness.buildMoveWithOrders();
+    const userId = move.Orders.ServiceMember.user_id;
+    await customerPage.signInAsExistingCustomer(userId);
+
+    // Navigate to create a new shipment
+    await customerPage.waitForPage.home();
+    await page.getByTestId('shipment-selection-btn').click();
+    await customerPage.waitForPage.aboutShipments();
+    await customerPage.navigateForward();
+    await customerPage.waitForPage.selectShipmentType();
+
+    // Create an Mobile Home shipment
+    await page.getByText('Move a Mobile Home').click();
+    await customerPage.navigateForward();
+
+    // Fill in form to create Mobile Home shipment
+    await customerPage.waitForPage.mobileHomeShipment();
+    await page.getByLabel('Year').fill('2022');
+    await page.getByLabel('Make').fill('make');
+    await page.getByLabel('Model').fill('model');
+    await page.getByTestId('lengthFeet').fill('22');
+    await page.getByTestId('widthFeet').fill('22');
+    await page.getByTestId('heightFeet').fill('22');
+    await page.getByRole('button', { name: 'Continue' }).click();
+
+    await expect(page.getByTestId('tag')).toContainText('Mobile Home');
+
+    await expect(page.getByText('Pickup info')).toBeVisible();
+    await page.getByLabel('Preferred pickup date').fill('25 Dec 2022');
+    await page.getByLabel('Preferred pickup date').blur();
+    await page.getByText('Use my current address').click();
+    await page.getByLabel('Preferred delivery date').fill('25 Dec 2022');
+    await page.getByLabel('Preferred delivery date').blur();
+    await page.getByRole('button', { name: 'Save & Continue' }).click();
+    await customerPage.waitForPage.reviewShipments();
+  });
+});
+
+test.describe('(MultiMove) Mobile Home shipment', () => {
+  test.skip(multiMoveEnabled === 'false', 'Skip if MultiMove workflow is not enabled.');
+
+  test('A customer can create a Mobile Home shipment', async ({ page, customerPage }) => {
+    // Generate a new onboarded user with orders and log in
+    const move = await customerPage.testHarness.buildMoveWithOrders();
+    const userId = move.Orders.ServiceMember.user_id;
+    await customerPage.signInAsExistingCustomer(userId);
+
+    // Navigate from MM Dashboard to Move
+    await customerPage.navigateFromMMDashboardToMove(move);
+
+    // Navigate to create a new shipment
+    await customerPage.waitForPage.home();
+    await page.getByTestId('shipment-selection-btn').click();
+    await customerPage.waitForPage.aboutShipments();
+    await customerPage.navigateForward();
+    await customerPage.waitForPage.selectShipmentType();
+
+    // Create an Mobile Home shipment
+    await page.getByText('Move a mobile home').click();
+    await customerPage.navigateForward();
+
+    // Fill in form to create Mobile Home shipment
+    await customerPage.waitForPage.mobileHomeShipment();
+    await page.getByLabel('Year').fill('2022');
+    await page.getByLabel('Make').fill('make');
+    await page.getByLabel('Model').fill('model');
+    await page.getByTestId('lengthFeet').fill('22');
+    await page.getByTestId('widthFeet').fill('22');
+    await page.getByTestId('heightFeet').fill('22');
+    await page.getByRole('button', { name: 'Continue' }).click();
+
+    await expect(page.getByTestId('tag')).toContainText('Mobile Home');
+
+    await expect(page.getByText('Pickup info')).toBeVisible();
+    await page.getByLabel('Preferred pickup date').fill('25 Dec 2022');
+    await page.getByLabel('Preferred pickup date').blur();
+    await page.getByText('Use my current address').click();
+    await page.getByLabel('Preferred delivery date').fill('25 Dec 2022');
+    await page.getByLabel('Preferred delivery date').blur();
+    await page.getByRole('button', { name: 'Save & Continue' }).click();
+    await customerPage.waitForPage.reviewShipments();
+  });
+
+  test('Is able to delete a Mobile Home shipment', async ({ page, customerPage }) => {
+    // Generate a new onboarded user with orders and log in
+    const move = await customerPage.testHarness.buildMoveWithOrders();
+    const userId = move.Orders.ServiceMember.user_id;
+    await customerPage.signInAsExistingCustomer(userId);
+
+    // Navigate from MM Dashboard to Move
+    await customerPage.navigateFromMMDashboardToMove(move);
+
+    // Navigate to create a new shipment
+    await customerPage.waitForPage.home();
+    await page.getByTestId('shipment-selection-btn').click();
+    await customerPage.waitForPage.aboutShipments();
+    await customerPage.navigateForward();
+    await customerPage.waitForPage.selectShipmentType();
+
+    // Create an Mobile Home shipment
+    await page.getByText('Move a mobile home').click();
+    await customerPage.navigateForward();
+
+    // Fill in form to create Mobile Home shipment
+    await customerPage.waitForPage.mobileHomeShipment();
+    await page.getByLabel('Year').fill('2022');
+    await page.getByLabel('Make').fill('make');
+    await page.getByLabel('Model').fill('model');
+    await page.getByTestId('lengthFeet').fill('22');
+    await page.getByTestId('widthFeet').fill('22');
+    await page.getByTestId('heightFeet').fill('22');
+    await page.getByRole('button', { name: 'Continue' }).click();
+
+    await expect(page.getByTestId('tag')).toContainText('Mobile Home');
+
+    await expect(page.getByText('Pickup info')).toBeVisible();
+    await page.getByLabel('Preferred pickup date').fill('25 Dec 2022');
+    await page.getByLabel('Preferred pickup date').blur();
+    await page.getByText('Use my current address').click();
+    await page.getByLabel('Preferred delivery date').fill('25 Dec 2022');
+    await page.getByLabel('Preferred delivery date').blur();
+    await page.getByRole('button', { name: 'Save & Continue' }).click();
+    await customerPage.waitForPage.reviewShipments();
+
+    await expect(page.getByRole('heading', { name: 'Mobile Home 1' })).toBeVisible();
+    await page.getByTestId('deleteShipmentButton').click();
+    await expect(page.getByRole('heading', { name: 'Delete this?' })).toBeVisible();
+    await page.getByText('Yes, Delete').click();
+
+    await expect(page.getByRole('heading', { name: 'Mobile Home 1' })).not.toBeVisible();
+  });
+});

playwright/tests/utils/my/waitForCustomerPage.js

@@ -193,6 +193,15 @@ export class WaitForCustomerPage extends WaitForPage {
     await this.runAccessibilityAudit();
   }
 
+  /**
+   * @returns {Promise<void>}
+   */
+  async mobileHomeShipment() {
+    await this.runAccessibilityAudit();
+    await base.expect(this.page.getByRole('heading', { level: 1 })).toHaveText('Mobile Home details and measurements');
+    await this.runAccessibilityAudit();
+  }
+
   /**
    * @returns {Promise<void>}
    */

src/components/Customer/BoatShipment/BoatShipmentForm/BoatShipmentForm.jsx

@@ -333,7 +333,7 @@ const BoatShipmentForm = ({ mtoShipment, onBack, onSubmit }) => {
                     Examples
                     <ul>
                       <li>
-                        Dimensions of the boat on the trailer are signigicantly different than one would expect given
+                        Dimensions of the boat on the trailer are significantly different than one would expect given
                         their individual dimensions
                       </li>
 

src/components/Customer/MobileHomeShipment/MobileHomeShipmentForm/MobileHomeShipmentForm.jsx

@@ -110,7 +110,7 @@ const MobileHomeShipmentForm = ({ mtoShipment, onBack, onSubmit }) => {
           <div className={styles.formContainer}>
             <Form className={formStyles.form}>
               <SectionWrapper className={classnames(styles.sectionWrapper, formStyles.formSection, 'origin')}>
-                <h2>Mobile home Information</h2>
+                <h2>Mobile Home Information</h2>
                 <div className="grid-row grid-gap">
                   <div className="mobile-lg:grid-col-3">
                     <MaskedTextField
@@ -142,7 +142,7 @@ const MobileHomeShipmentForm = ({ mtoShipment, onBack, onSubmit }) => {
               </SectionWrapper>
               <SectionWrapper className={classnames(styles.sectionWrapper, formStyles.formSection, 'origin')}>
                 <h2>Mobile Home Dimensions</h2>
-                <p>Enter all of the dimensions of the mobile home.</p>
+                <p>Enter the total outside dimensions (in Feet and Inches) of the Mobile Home.</p>
                 <div>
                   <Fieldset className={styles.formFieldContainer}>
                     <div className="labelWrapper">
@@ -268,14 +268,12 @@ const MobileHomeShipmentForm = ({ mtoShipment, onBack, onSubmit }) => {
                   </Label>
 
                   <Callout>
-                    Examples
+                    Example
                     <ul>
                       <li>
-                        Dimensions of the mobile home on the trailer are signigicantly different than one would expect
-                        given their individual dimensions
+                        Is there additional information you feel is pertinent to the processing of your mobile home
+                        shipment?(e.g., &lsquo;wrecker service requested&rsquo; and &lsquo;crane service needed&rsquo;).
                       </li>
-
-                      <li>Access info for your origin or destination address/marina</li>
                     </ul>
                   </Callout>
 

src/components/Customer/MtoShipmentForm/MtoShipmentForm.jsx

@@ -628,7 +628,7 @@ class MtoShipmentForm extends Component {
                         </SectionWrapper>
                       )}
 
-                      {!isBoat && (
+                      {!isBoat && !isMobileHome && (
                         <SectionWrapper className={formStyles.formSection}>
                           <Fieldset legend={<div className={formStyles.legendContent}>Remarks</div>}>
                             <Label htmlFor="customerRemarks">

src/components/Customer/Review/ShipmentCard/MobileHomeShipmentCard/MobileHomeshipmentCard.test.jsx

@@ -0,0 +1,143 @@
+import React from 'react';
+import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+
+import MobileHomeShipmentCard from './MobileHomeShipmentCard';
+
+import { SHIPMENT_TYPES } from 'shared/constants';
+
+const defaultProps = {
+  showEditAndDeleteBtn: true,
+  onEditClick: jest.fn(),
+  onDeleteClick: jest.fn(),
+  shipmentNumber: 1,
+  requestedPickupDate: new Date('01/01/2020').toISOString(),
+  requestedDeliveryDate: new Date('03/01/2020').toISOString(),
+  pickupLocation: {
+    streetAddress1: '17 8th St',
+    city: 'New York',
+    state: 'NY',
+    postalCode: '11111',
+  },
+  destinationLocation: {
+    streetAddress1: '17 8th St',
+    city: 'New York',
+    state: 'NY',
+    postalCode: '73523',
+  },
+  releasingAgent: {
+    firstName: 'Super',
+    lastName: 'Mario',
+    phone: '(555) 555-5555',
+    email: 'superMario@gmail.com',
+  },
+  destinationZIP: '73523',
+  receivingAgent: {
+    firstName: 'Princess',
+    lastName: 'Peach',
+    phone: '(999) 999-9999',
+    email: 'princessPeach@gmail.com',
+  },
+  remarks:
+    'This is 500 characters of customer remarks right here. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.',
+  shipment: {
+    moveTaskOrderID: 'testMove123',
+    id: '20fdbf58-879e-4692-b3a6-8a71f6dcfeaa',
+    shipmentLocator: 'testMove123-01',
+    shipmentType: SHIPMENT_TYPES.MOBILE_HOME,
+    mobileHomeShipment: {
+      year: 2020,
+      make: 'Test Make',
+      model: 'Test Model',
+      lengthInInches: 240,
+      widthInInches: 120,
+      heightInInches: 72,
+    },
+  },
+};
+
+describe('MobileHomeShipmentCard component', () => {
+  it('renders component with all fields', () => {
+    render(<MobileHomeShipmentCard {...defaultProps} />);
+
+    expect(screen.getByRole('heading', { level: 3 })).toHaveTextContent('Mobile Home 1');
+    expect(screen.getByText(/^#testMove123-01$/, { selector: 'p' })).toBeInTheDocument();
+
+    expect(screen.getByRole('button', { name: 'Edit' })).toBeInTheDocument();
+    expect(screen.getByRole('button', { name: 'Delete' })).toBeInTheDocument();
+
+    const descriptionDefinitions = screen.getAllByRole('definition');
+
+    const expectedRows = [
+      ['Requested pickup date', '01 Jan 2020'],
+      ['Pickup location', '17 8th St New York, NY 11111'],
+      ['Releasing agent', 'Super Mario (555) 555-5555 superMario@gmail.com'],
+      ['Requested delivery date', '01 Mar 2020'],
+      ['Destination', '17 8th St New York, NY 73523'],
+      ['Receiving agent', 'Princess Peach (999) 999-9999 princessPeach@gmail.com'],
+      ['Mobile Home year', '2020'],
+      ['Mobile Home make', 'Test Make'],
+      ['Mobile Home model', 'Test Model'],
+      ['Dimensions', `20' L x 10' W x 6' H`],
+      [
+        'Remarks',
+        'This is 500 characters of customer remarks right here. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.',
+      ],
+    ];
+
+    expect(descriptionDefinitions.length).toBe(expectedRows.length);
+
+    expectedRows.forEach((expectedRow, index) => {
+      // dt (definition terms) are not accessible elements that can be found with getByRole although
+      // testing library claims this is fixed we need to find the node package that is out of date
+      expect(descriptionDefinitions[index].previousElementSibling).toHaveTextContent(expectedRow[0]);
+      expect(descriptionDefinitions[index]).toHaveTextContent(expectedRow[1]);
+    });
+  });
+
+  it('omits the edit button when showEditAndDeleteBtn prop is false', () => {
+    render(<MobileHomeShipmentCard {...defaultProps} showEditAndDeleteBtn={false} />);
+
+    expect(screen.queryByRole('button', { name: 'Edit' })).not.toBeInTheDocument();
+    expect(screen.queryByRole('button', { name: 'Delete' })).not.toBeInTheDocument();
+  });
+
+  it('calls onEditClick when edit button is pressed', async () => {
+    render(<MobileHomeShipmentCard {...defaultProps} />);
+    const editBtn = screen.getByRole('button', { name: 'Edit' });
+    await userEvent.click(editBtn);
+    expect(defaultProps.onEditClick).toHaveBeenCalledTimes(1);
+  });
+
+  it('calls onDeleteClick when delete button is pressed', async () => {
+    render(<MobileHomeShipmentCard {...defaultProps} />);
+    const deleteBtn = screen.getByRole('button', { name: 'Delete' });
+    await userEvent.click(deleteBtn);
+    expect(defaultProps.onDeleteClick).toHaveBeenCalledTimes(1);
+  });
+
+  it('renders incomplete shipment label and tooltip when shipment is incomplete', async () => {
+    const incompleteShipmentProps = {
+      ...defaultProps,
+      shipment: {
+        ...defaultProps.shipment,
+        requestedPickupDate: '',
+        mobileHomeShipment: defaultProps.shipment.mobileHomeShipment,
+      },
+      onIncompleteClick: jest.fn(),
+    };
+
+    render(<MobileHomeShipmentCard {...incompleteShipmentProps} />);
+
+    expect(screen.getByText('Incomplete')).toBeInTheDocument();
+    expect(screen.getByTitle('Help about incomplete shipment')).toBeInTheDocument();
+
+    await userEvent.click(screen.getByTitle('Help about incomplete shipment'));
+
+    expect(incompleteShipmentProps.onIncompleteClick).toHaveBeenCalledWith(
+      'Mobile Home 1',
+      'testMove123-01',
+      SHIPMENT_TYPES.MOBILE_HOME,
+    );
+  });
+});

src/components/Customer/Review/Summary/Summary.test.jsx

@@ -666,6 +666,7 @@ describe('Summary page', () => {
       expect(isBooleanFlagEnabled).toBeCalledWith(FEATURE_FLAG_KEYS.NTS);
       expect(isBooleanFlagEnabled).toBeCalledWith(FEATURE_FLAG_KEYS.NTSR);
       expect(isBooleanFlagEnabled).toBeCalledWith(FEATURE_FLAG_KEYS.BOAT);
+      expect(isBooleanFlagEnabled).toBeCalledWith(FEATURE_FLAG_KEYS.MOBILE_HOME);
     });
 
     it('add shipment modal displays still in dev mode', async () => {
@@ -697,6 +698,7 @@ describe('Summary page', () => {
       expect(isBooleanFlagEnabled).toBeCalledWith(FEATURE_FLAG_KEYS.NTS);
       expect(isBooleanFlagEnabled).toBeCalledWith(FEATURE_FLAG_KEYS.NTSR);
       expect(isBooleanFlagEnabled).toBeCalledWith(FEATURE_FLAG_KEYS.BOAT);
+      expect(isBooleanFlagEnabled).toBeCalledWith(FEATURE_FLAG_KEYS.MOBILE_HOME);
     });
   });
   afterEach(jest.clearAllMocks);