Services test #13664
Merged
Services test #13664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-mettler
requested review from
deandreJones,
MInthavongsay,
antgmann,
ajlusk and
CoryKleinjanCACI
antgmann
approved these changes
Sep 9, 2024
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
traskowskycaci
approved these changes
Sep 9, 2024
ajlusk
approved these changes
Sep 10, 2024
cameroncaci
approved these changes
Sep 10, 2024
Very possible they just don't have tests. I found that the test for some reason cause the useEffect to be called multiple times which overrides the error message and sets it to null. UseEffect is supposed to be called on page render or if you specify variables in the useEffect it would call if those variable values changed. The value wasn't changing so my assumption is the tests cause multiple page renders to happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT PR
Summary
Fix flaky test for ServicesCounselingEditShipmentDetails.
This is due to the test setting the error message but the useEffect for the date holiday weekend check is being called and resets the error message to null.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots