Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services test #13664

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Services test #13664

merged 6 commits into from
Sep 10, 2024

Conversation

r-mettler
Copy link
Contributor

INT PR

Summary

Fix flaky test for ServicesCounselingEditShipmentDetails.
image

This is due to the test setting the error message but the useEffect for the date holiday weekend check is being called and resets the error message to null.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Run client tests several times and verify the flaky test does not display.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches (go mod and sum changes on int pr can be ignored)

@robot-mymove
Copy link

robot-mymove commented Sep 9, 2024

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against 512e3a4

Copy link

github-actions bot commented Sep 9, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
308 13.43 MB → 13.43 MB (+220 B) +0.00%
Changeset
File Δ Size
src/components/Office/ShipmentForm/ShipmentForm.jsx 📈 +345 B (+0.79%) 42.64 kB → 42.97 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
static/js/main.a2ddcb78.js 0 B → 786.19 kB (+786.19 kB) -
static/js/434.d4f4f706.chunk.js 0 B → 52.6 kB (+52.6 kB) -

Removed

Asset File Size % Changed
static/js/main.7947a8ff.js 786.19 kB → 0 B (-786.19 kB) -100%
static/js/434.485a91da.chunk.js 52.38 kB → 0 B (-52.38 kB) -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/8946.a8964a6c.chunk.js 1.38 MB 0%
static/js/9043.1e83935c.chunk.js 861.86 kB 0%
static/css/2392.fe60288c.chunk.css 688.35 kB 0%
static/css/1810.b589a95d.chunk.css 664.08 kB 0%
static/css/885.7d8fcd20.chunk.css 663.85 kB 0%
static/media/hero.bf01157b9686e90e34dd.png 609.24 kB 0%
static/css/9742.ecd6daa1.chunk.css 508.36 kB 0%
static/css/8810.9d9fe838.chunk.css 455.07 kB 0%
static/css/3710.0f3ea339.chunk.css 453.75 kB 0%
static/css/4987.47d4c67a.chunk.css 422.99 kB 0%
static/js/2548.c31aa081.chunk.js 334.66 kB 0%
static/js/9742.4ec67e8e.chunk.js 250.93 kB 0%
static/js/2271.af4d7477.chunk.js 154.5 kB 0%
static/js/8757.87e6b91e.chunk.js 112.35 kB 0%
static/js/1121.69de6e47.chunk.js 108.47 kB 0%
static/js/4833.0c49caf9.chunk.js 106.66 kB 0%
static/js/5883.da0a121c.chunk.js 100.3 kB 0%
static/js/7764.d216b6f4.chunk.js 88.51 kB 0%
static/media/PublicSans-Regular.af5c059f36e21e13f39f.ttf 78.03 kB 0%
static/media/PublicSans-Light.839012ec5b7d44a46954.ttf 77.91 kB 0%
static/media/PublicSans-Italic.642113a6a2f365350349.ttf 77.7 kB 0%
static/media/PublicSans-Bold.a52885b904d32280b208.ttf 77.61 kB 0%
static/media/PublicSans-LightItalic.49a5ea322c6c3762b921.ttf 77.44 kB 0%
static/media/PublicSans-BoldItalic.cbc51dd94deab4465d42.ttf 77.41 kB 0%
static/media/transcom-emblem.bcb580b55633c358c82d89f4798081c5.svg 65.22 kB 0%
static/js/6854.8ac4d3c6.chunk.js 63.31 kB 0%
static/js/3502.5c1d6e28.chunk.js 60.3 kB 0%
static/js/4690.1d8fce21.chunk.js 59.09 kB 0%
static/js/1964.0ce1e044.chunk.js 55.38 kB 0%
static/js/5811.5371566f.chunk.js 54.4 kB 0%
static/media/sourcesanspro-light-webfont.d6f73cf7210d3b5c2fa9.ttf 53.23 kB 0%
static/media/sourcesanspro-regular-webfont.5acfe0d0f69444765ba4.ttf 53.16 kB 0%
static/media/sourcesanspro-bold-webfont.9a76932911f04be25044.ttf 53.07 kB 0%
static/js/5588.cf16a060.chunk.js 52.76 kB 0%
static/js/5448.56e637cc.chunk.js 50.96 kB 0%
static/css/1121.077ab8c9.chunk.css 48.81 kB 0%
static/media/Latin-Merriweather-Regular.43dc3080728216519bf0.ttf 48.32 kB 0%
static/media/Latin-Merriweather-Light.30dd683b4fcfe95b030b.ttf 48.01 kB 0%
static/media/Latin-Merriweather-Bold.b87366633b1019e8c63c.ttf 46.12 kB 0%
static/css/5883.ee85129d.chunk.css 45.49 kB 0%
asset-manifest.json 41.42 kB 0%
static/js/447.e1921258.chunk.js 40.04 kB 0%
static/media/PublicSans-BoldItalic.6bb0cb126756efec5fa5.woff 39.72 kB 0%
static/media/PublicSans-Italic.333d9a80b7b3b003b3c5.woff 39.57 kB 0%
static/media/PublicSans-LightItalic.4c86a8eb158c949923dd.woff 39.53 kB 0%
static/media/Latin-Merriweather-BoldItalic.4d74f3bda45f5aba1abf.ttf 39.52 kB 0%
static/media/PublicSans-Light.8460a3397f2ffc7d22d0.woff 39.23 kB 0%
static/media/PublicSans-Regular.f32753567f64c1ddeec8.woff 39.17 kB 0%
static/media/PublicSans-Bold.8c3655e2b925bcad90cd.woff 39.11 kB 0%
static/media/Latin-Merriweather-Italic.b60043e65fa5cbcedb80.ttf 38.55 kB 0%
static/media/Latin-Merriweather-LightItalic.26ebdd3b8f1d039bc3dd.ttf 38.53 kB 0%
static/media/sourcesanspro-lightitalic-webfont.43ea3d39e6aa59fb6f1b.ttf 38.23 kB 0%
static/media/sourcesanspro-italic-webfont.3efee318468995ac04af.ttf 37.94 kB 0%
static/media/sourcesanspro-bolditalic-webfont.af3dd40e0ac8e2ca50ac.ttf 37.85 kB 0%
static/js/4699.1fc98858.chunk.js 37 kB 0%
static/css/7764.52e1ad19.chunk.css 36.53 kB 0%
static/js/1450.674d183e.chunk.js 34.99 kB 0%
static/js/5054.7406534d.chunk.js 34.37 kB 0%
static/js/1007.03030700.chunk.js 33.5 kB 0%
static/media/PublicSans-BoldItalic.effa83ee2a557ae8a57e.woff2 32.43 kB 0%
static/media/PublicSans-Italic.8be0a159b540a60fd93a.woff2 32.26 kB 0%
static/media/PublicSans-LightItalic.475db532b9392ec581c5.woff2 32.14 kB 0%
static/media/PublicSans-Light.4ba4759c3e98938156d7.woff2 31.84 kB 0%
static/media/roboto-mono-v5-latin-300italic.93511dbad22ceb584f03.ttf 31.83 kB 0%
static/media/roboto-mono-v5-latin-700italic.da78bf0b1b435f40ca19.ttf 31.8 kB 0%
static/media/PublicSans-Regular.e86d2642f412b9493b14.woff2 31.79 kB 0%
static/js/9565.de1def7d.chunk.js 31.73 kB 0%
static/media/PublicSans-Bold.4045385082dfc34c22d7.woff2 31.64 kB 0%
static/media/roboto-mono-v5-latin-italic.4863add4d566a55b6a97.ttf 31.58 kB 0%
static/js/4987.e7ef9504.chunk.js 31.5 kB 0%
static/media/roboto-mono-v5-latin-300.ce3838471d62f8364e12.ttf 31.41 kB 0%
static/media/okta_logo.56ac9bdcdffeda24c715.png 31.3 kB 0%
static/js/1775.e1523174.chunk.js 30.75 kB 0%
static/media/roboto-mono-v5-latin-700.e57caf7ea634a258a9b2.ttf 30.36 kB 0%
static/media/roboto-mono-v5-latin-regular.215adb34128fcb20668b.ttf 30.32 kB 0%
static/js/9706.e24ba5c9.chunk.js 29.89 kB 0%
static/js/1377.ce688d32.chunk.js 28.84 kB 0%
static/js/1291.59350453.chunk.js 27.78 kB 0%
static/js/4637.1e44a217.chunk.js 27.51 kB 0%
static/media/Latin-Merriweather-Regular.add503b41601df15b97e.woff 26.87 kB 0%
static/js/1865.94f65291.chunk.js 26.47 kB 0%
static/media/Latin-Merriweather-Light.7b2a6350fcb212efe521.woff 26.36 kB 0%
static/media/Latin-Merriweather-Bold.b6cbc321678701d773c6.woff 26.26 kB 0%
static/js/6748.2c15a0b4.chunk.js 25.86 kB 0%
static/js/9049.5fff703e.chunk.js 25.61 kB 0%
static/media/sourcesanspro-regular-webfont.c4e25ab10baa365dfc66.woff 25.53 kB 0%
static/media/sourcesanspro-bold-webfont.e7e051e1bc64fa899317.woff 25.43 kB 0%
static/media/sourcesanspro-light-webfont.70e7d719e258c9a7e68b.woff 25.35 kB 0%
static/js/793.6915bcc5.chunk.js 24.74 kB 0%
static/js/2923.5ae1fb30.chunk.js 24.52 kB 0%
static/css/1865.f0ead447.chunk.css 24.46 kB 0%
static/js/6061.a618108e.chunk.js 24.42 kB 0%
static/js/4730.b94663b3.chunk.js 24.11 kB 0%
static/media/Latin-Merriweather-BoldItalic.a0bcf832ed51501c237c.woff 23.89 kB 0%
static/media/Latin-Merriweather-Italic.80d8a9aff0d8bdeb966d.woff 23.59 kB 0%
static/media/Latin-Merriweather-LightItalic.8a239a410a47b6192e05.woff 23.25 kB 0%
static/js/7979.fb8a69d3.chunk.js 22.16 kB 0%
static/js/1810.d5ccbb92.chunk.js 22.09 kB 0%
static/css/5054.1d76226e.chunk.css 21.78 kB 0%
static/js/7888.2e003e14.chunk.js 21.72 kB 0%
static/css/4637.febed199.chunk.css 21.41 kB 0%
static/media/Latin-Merriweather-Regular.a30c1b8fcb759e9fe728.woff2 21.18 kB 0%
static/css/9706.e93b74f9.chunk.css 21.04 kB 0%
static/media/Latin-Merriweather-Bold.9caa42f21e4ae090b755.woff2 20.81 kB 0%
static/media/Latin-Merriweather-Light.f347d9834a5feacbcefb.woff2 20.76 kB 0%
static/media/roboto-mono-v5-latin-700italic.0a6791447401e0ebd70d.woff 20.64 kB 0%
static/media/roboto-mono-v5-latin-italic.756750acefdb77704c08.woff 20.6 kB 0%
static/media/roboto-mono-v5-latin-300italic.1b8d46dae0a077f999ae.woff 20.56 kB 0%
static/js/9409.771876eb.chunk.js 20.38 kB 0%
static/js/1208.7767a0a8.chunk.js 20.29 kB 0%
static/css/2271.643cfb33.chunk.css 20.08 kB 0%
static/media/sourcesanspro-regular-webfont.e7bccfa631a0017f31da.woff2 20.06 kB 0%
static/media/sourcesanspro-light-webfont.e5f1a42e1c2b97e25876.woff2 19.93 kB 0%
static/media/sourcesanspro-bold-webfont.4a1efbe82eaa84ff89ed.woff2 19.89 kB 0%
static/media/sourcesanspro-lightitalic-webfont.455d120362f79aa219d4.woff 19.78 kB 0%
static/media/sourcesanspro-italic-webfont.0aaeabbaba3845331078.woff 19.73 kB 0%
static/media/sourcesanspro-bolditalic-webfont.73021f1aabd43f50e16a.woff 19.69 kB 0%
static/js/4136.a8ec2148.chunk.js 19.48 kB 0%
static/media/roboto-mono-v5-latin-300.92dd8f0ccfaebc33f817.woff 19.42 kB 0%
static/css/6061.a57a1de9.chunk.css 19.14 kB 0%
static/media/roboto-mono-v5-latin-regular.a3246d29b40a8b0da142.woff 19.12 kB 0%
static/js/9611.f94e99db.chunk.js 19.12 kB 0%
static/media/Latin-Merriweather-BoldItalic.dc8b76b44a8a6e5fad1c.woff2 19.11 kB 0%
static/media/roboto-mono-v5-latin-700.d85b43c39f4620dfa5b4.woff 19.11 kB 0%
static/media/Latin-Merriweather-Italic.c63d4066b0f133fc519f.woff2 18.8 kB 0%
static/media/Latin-Merriweather-LightItalic.506121dad559538d44ed.woff2 18.53 kB 0%
static/css/434.c5925d71.chunk.css 18.45 kB 0%
static/media/smart-card.c810117aa96a9adbd31b.png 18.39 kB 0%
static/js/9740.2313e1fe.chunk.js 18.37 kB 0%
static/js/551.e9621cf2.chunk.js 18.07 kB 0%
static/media/roboto-mono-v5-latin-300italic.09cc62a8fbd32c8b2812.woff2 16.93 kB 0%
static/media/roboto-mono-v5-latin-700italic.5a8f743549cc6cef9a00.woff2 16.93 kB 0%
static/media/sad-computer.b62f031230f84d7db1b1.png 16.92 kB 0%
static/media/roboto-mono-v5-latin-italic.087069a9f454e2581ed6.woff2 16.91 kB 0%
static/js/4417.c9d82412.chunk.js 16.41 kB 0%
static/js/9875.f9fb8d2f.chunk.js 16.04 kB 0%
static/css/1775.8d5f2577.chunk.css 16.04 kB 0%
static/media/sourcesanspro-bolditalic-webfont.ef69f0d737406260319a.woff2 16.03 kB 0%
static/media/roboto-mono-v5-latin-300.316b1352cc4ab2054de6.woff2 16 kB 0%
static/media/sourcesanspro-italic-webfont.c6c9fd228e87eefaf1d4.woff2 15.99 kB 0%
static/media/sourcesanspro-lightitalic-webfont.9c5bf2190b2471c2f22b.woff2 15.93 kB 0%
static/media/roboto-mono-v5-latin-regular.f1dc10a756c2c544588b.woff2 15.65 kB 0%
static/media/roboto-mono-v5-latin-700.936869ba46988c238748.woff2 15.58 kB 0%
static/js/2680.ce715e10.chunk.js 15.16 kB 0%
static/js/8693.c10df4d3.chunk.js 15.09 kB 0%
static/js/4573.b9766c7c.chunk.js 15.03 kB 0%
static/js/6350.7b6d51b1.chunk.js 14.75 kB 0%
static/js/2392.efdf255a.chunk.js 14.74 kB 0%
static/js/4272.8a2b8c06.chunk.js 14.7 kB 0%
static/js/6411.bb78f854.chunk.js 14.59 kB 0%
static/js/7119.f1425b75.chunk.js 14.54 kB 0%
static/js/6696.11739307.chunk.js 13.91 kB 0%
static/js/5151.d0468457.chunk.js 13.73 kB 0%
static/css/7979.b33e9aed.chunk.css 13.44 kB 0%
static/js/5325.c353b468.chunk.js 13.42 kB 0%
static/css/4730.794d45a9.chunk.css 13.36 kB 0%
static/js/7822.33525771.chunk.js 13.33 kB 0%
static/js/1554.27999100.chunk.js 13.31 kB 0%
static/css/7119.d06b6b98.chunk.css 13.28 kB 0%
static/css/1208.02edb420.chunk.css 12.99 kB 0%
static/js/5426.9af1f789.chunk.js 12.89 kB 0%
static/css/1007.60c30fb0.chunk.css 12.17 kB 0%
static/css/9049.60c30fb0.chunk.css 12.17 kB 0%
static/css/1255.779d23d6.chunk.css 11.92 kB 0%
static/css/4371.779d23d6.chunk.css 11.92 kB 0%
static/css/6752.779d23d6.chunk.css 11.92 kB 0%
static/css/3933.0d60e105.chunk.css 11.81 kB 0%
static/js/3665.5614cae8.chunk.js 11.7 kB 0%
static/css/6475.824f4a42.chunk.css 11.65 kB 0%
static/css/6931.824f4a42.chunk.css 11.65 kB 0%
static/css/4272.60e2ded5.chunk.css 11.51 kB 0%
static/js/9414.dd4a5b8f.chunk.js 11.5 kB 0%
static/css/9565.aea20b90.chunk.css 11.5 kB 0%
static/js/7104.cf779a68.chunk.js 11.33 kB 0%
static/js/538.6fe9604a.chunk.js 11.28 kB 0%
static/js/8797.061c0b48.chunk.js 11.07 kB 0%
static/css/1291.cb6eaaf4.chunk.css 10.95 kB 0%
static/js/9284.79678e27.chunk.js 10.84 kB 0%
static/js/8960.89b793f5.chunk.js 10.66 kB 0%
static/js/9802.61456f36.chunk.js 10.5 kB 0%
static/js/5091.7c4f6ef7.chunk.js 10.42 kB 0%
static/js/9692.7c4576b7.chunk.js 10.27 kB 0%
static/js/8167.5d886339.chunk.js 10.02 kB 0%
static/js/7612.47ba4519.chunk.js 9.74 kB 0%
static/css/1377.9defe522.chunk.css 9.55 kB 0%
static/js/3933.b639864d.chunk.js 9.5 kB 0%
static/js/6462.21d5c9b4.chunk.js 9.44 kB 0%
static/js/4266.7d4b0ea2.chunk.js 9.25 kB 0%
static/js/4098.a6f4266d.chunk.js 9.24 kB 0%
static/css/4417.3ff0b4e7.chunk.css 9.03 kB 0%
static/css/7822.3258d177.chunk.css 9.02 kB 0%
static/js/4371.616ad2d7.chunk.js 9 kB 0%
static/js/1761.6a3b5b3b.chunk.js 8.97 kB 0%
static/js/6536.08a3a103.chunk.js 8.88 kB 0%
static/js/6368.56891c0e.chunk.js 8.75 kB 0%
static/js/5560.bfbb8c56.chunk.js 8.5 kB 0%
static/js/9739.b8351d09.chunk.js 8.28 kB 0%
static/js/2823.d9a45aa8.chunk.js 8.22 kB 0%
static/css/5811.3f97679d.chunk.css 8.04 kB 0%
static/css/9284.26ddefc2.chunk.css 7.99 kB 0%
static/css/4535.40e50b61.chunk.css 7.92 kB 0%
static/css/5455.40e50b61.chunk.css 7.92 kB 0%
static/js/1453.1a47dfdc.chunk.js 7.85 kB 0%
static/css/6951.f4050a15.chunk.css 7.82 kB 0%
static/css/1761.d70000ae.chunk.css 7.72 kB 0%
static/css/3665.7e57832d.chunk.css 7.66 kB 0%
static/css/4573.c9edb210.chunk.css 7.36 kB 0%
static/js/4828.be04f13a.chunk.js 7.18 kB 0%
static/js/885.1909eecd.chunk.js 7.06 kB 0%
static/css/5952.23a390aa.chunk.css 6.73 kB 0%
static/css/8884.23a390aa.chunk.css 6.73 kB 0%
static/css/6462.131dcdd9.chunk.css 6.53 kB 0%
static/js/8552.03edcc34.chunk.js 6 kB 0%
static/js/396.52b27b35.chunk.js 5.48 kB 0%
static/css/8093.c243facd.chunk.css 5.45 kB 0%
static/media/milmove-logo.c977261e059ba42b2b70ba95cfb3d3de.svg 5.4 kB 0%
static/js/5280.3b4e7ac2.chunk.js 5.36 kB 0%
static/css/1453.3262014d.chunk.css 5.35 kB 0%
static/js/4246.f115f535.chunk.js 5.16 kB 0%
static/css/9692.91ee7ddc.chunk.css 4.75 kB 0%
static/js/2283.d9689df6.chunk.js 4.74 kB 0%
static/js/5952.7813cec6.chunk.js 4.7 kB 0%
static/css/5560.8cd86e2b.chunk.css 4.53 kB 0%
static/js/4772.8e680e13.chunk.js 4.49 kB 0%
static/css/6368.bbc00861.chunk.css 4.4 kB 0%
static/js/177.f8d948b9.chunk.js 4.12 kB 0%
static/js/1224.0e72db8a.chunk.js 4.11 kB 0%
static/js/8884.a0a0a58c.chunk.js 3.98 kB 0%
static/css/7612.7f6e106e.chunk.css 3.94 kB 0%
static/css/8167.849b6a40.chunk.css 3.89 kB 0%
static/css/4098.97493b47.chunk.css 3.84 kB 0%
static/css/2823.3dd5d616.chunk.css 3.8 kB 0%
static/css/9739.3dd5d616.chunk.css 3.8 kB 0%
static/js/6475.9746c921.chunk.js 3.6 kB 0%
static/js/4081.67c244f2.chunk.js 3.3 kB 0%
static/css/5426.c785fdaf.chunk.css 3.27 kB 0%
static/css/2680.26e049de.chunk.css 3.25 kB 0%
static/css/5448.52b0f792.chunk.css 3.14 kB 0%
static/js/6752.3c6533f5.chunk.js 2.95 kB 0%
static/js/1711.921429ec.chunk.js 2.93 kB 0%
static/js/9282.ffd51022.chunk.js 2.78 kB 0%
static/css/9414.1e52fa0b.chunk.css 2.77 kB 0%
static/css/4246.bc5e90af.chunk.css 2.6 kB 0%
static/js/8656.66f15362.chunk.js 2.57 kB 0%
static/css/396.96394823.chunk.css 2.5 kB 0%
static/css/5091.652fa3fa.chunk.css 2.49 kB 0%
static/js/7713.46facec3.chunk.js 2.34 kB 0%
static/js/85.737d973a.chunk.js 2.21 kB 0%
static/css/2178.d45c6948.chunk.css 2.04 kB 0%
static/css/9797.35c45fc7.chunk.css 2.04 kB 0%
static/css/8797.d46112ee.chunk.css 1.99 kB 0%
static/js/1255.4b97e70b.chunk.js 1.97 kB 0%
static/css/1224.6facdf3f.chunk.css 1.96 kB 0%
static/css/7713.7b9e081a.chunk.css 1.88 kB 0%
static/css/85.7b9e081a.chunk.css 1.88 kB 0%
static/js/2178.df77f988.chunk.js 1.79 kB 0%
static/js/9797.2ccadc05.chunk.js 1.78 kB 0%
static/media/loader.10d2d7c0a681e4e825da.svg 1.67 kB 0%
static/js/6951.b4a5488d.chunk.js 1.38 kB 0%
static/css/main.5749796c.css 1.27 kB 0%
static/js/6931.e9d7afb1.chunk.js 1.16 kB 0%
static/media/accept-inversed.91ff05235fdd54954706eab64123a3d5.svg 1.14 kB 0%
static/js/5455.cf0976d7.chunk.js 1.11 kB 0%
static/css/177.b6d7c517.chunk.css 1.03 kB 0%
static/css/9282.ab6699ac.chunk.css 960 B 0%
static/media/file-pdf.51bdb15e1e5b831bcf29.svg 904 B 0%
static/js/4124.f6d79fda.chunk.js 876 B 0%
static/js/2967.2acff7e1.chunk.js 874 B 0%
static/css/2283.f5d3a96b.chunk.css 852 B 0%
static/media/file-word.277ffb94e7a09f8a2d1a.svg 760 B 0%
static/media/file-excel.d002b7e57fe318badf49.svg 658 B 0%
static/css/9875.dc11b7b8.chunk.css 609 B 0%
static/media/correct8-alt.30d16a7a68f9063d3141.svg 607 B 0%
static/css/5280.0d997fb0.chunk.css 601 B 0%
static/media/correct8.eac85396da602db01ea3.svg 600 B 0%
index.html 595 B 0%
static/media/twitter.a8c1622d4e18b18caa167dbe0e31135b.svg 588 B 0%
static/media/file-video.15490fa6d64ebfb4f314.svg 574 B 0%
static/css/8960.8fb0844e.chunk.css 531 B 0%
static/css/4124.0b21f13e.chunk.css 462 B 0%
static/media/navigate_far_before.8c7765f1f2719ccdf3e5.svg 403 B 0%
static/media/navigate_far_next.602e9c473cc76474ac50.svg 402 B 0%
static/media/search.bc2178ae2f929aec5f09.svg 372 B 0%
static/media/facebook.9d8980817d35c2617cf1ebb5a833369a.svg 346 B 0%
static/media/file.7e80f971a49227f49f7e.svg 283 B 0%
static/media/launch--white.4e75d17dfe08a3d7de03.svg 283 B 0%
static/media/launch.65e057b210ca1e5d086e.svg 268 B 0%
static/media/unfold_more.c42abd3e70207a863184.svg 257 B 0%
static/media/check_circle.afe00fa2d228d8e9212e.svg 255 B 0%
static/media/calendar_today.26e6a18c4fb766a6307e.svg 248 B 0%
static/media/error--white.7f8e755b649a0ca72ce5.svg 246 B 0%
static/media/close.53c9f4b6ba9fca553d1e.svg 239 B 0%
static/media/error.57f310a26aa85a42d2a6.svg 234 B 0%
static/media/info.b15cdce316c440127b62.svg 234 B 0%
static/css/6536.c0be8b5e.chunk.css 227 B 0%
static/media/check--blue-60v.c60440495de32668463f.svg 202 B 0%
static/media/arrow_back.037e7aeb3dbe35a36ea6.svg 198 B 0%
static/media/warning.9fcdc101f630d1fd1e97.svg 188 B 0%
static/media/expand_less.018f82c5d61abf0ebfce.svg 184 B 0%
static/media/navigate_before.f280e5b722fcf18e18a9.svg 184 B 0%
static/media/navigate_next.00940e89d53796e4fc95.svg 184 B 0%
static/media/expand_more.7bdcd63935a4c23e5b72.svg 182 B 0%
static/media/add.0ddb797a0b4996c9f281.svg 173 B 0%
static/media/remove.fb2b121df150d251453a.svg 155 B 0%
static/css/1711.9fa21f2c.chunk.css 133 B 0%
static/css/4828.241dfdc5.chunk.css 133 B 0%

Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hash matches up with INT PR

Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches INT. Test passes locally too. I've encountered similar behavior with other error messages, those must not have tests. Definitely something to keep an eye out for in other places.

Copy link
Contributor

@deandreJones deandreJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!!!

@r-mettler
Copy link
Contributor Author

Matches INT. Test passes locally too. I've encountered similar behavior with other error messages, those must not have tests. Definitely something to keep an eye out for in other places.

Very possible they just don't have tests. I found that the test for some reason cause the useEffect to be called multiple times which overrides the error message and sets it to null. UseEffect is supposed to be called on page render or if you specify variables in the useEffect it would call if those variable values changed. The value wasn't changing so my assumption is the tests cause multiple page renders to happen.

@r-mettler r-mettler merged commit 980e638 into main Sep 10, 2024
42 checks passed
@r-mettler r-mettler deleted the servicesTest branch September 10, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

7 participants