Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20653 Mobile Home ShipmentCard destination Kickback #13687

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

KonstanceH
Copy link
Contributor

@KonstanceH KonstanceH commented Sep 11, 2024

Agility ticket

Summary

First integration PR: #13620
This PR addresses the issue of not seeing the destination delivery address when the customer doesn't provide a destination street address.

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Login as a customer
  2. Add a mobile home shipment to your move
    2a. Fill out necessary information
    2b. Check 'No' on "Do you know your delivery address yet?" section
    2c. Complete adding shipment
  3. Confirm street address is 'N/A' and city, state, zip is provided on shipment card

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

Screenshot 2024-09-11 at 9 43 12 AM

@KonstanceH KonstanceH self-assigned this Sep 11, 2024
@KonstanceH KonstanceH added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Sep 11, 2024
@KonstanceH KonstanceH changed the title add destination check for mobile home 20653 Mobile Home ShipmentCard destination KICKBACK Sep 11, 2024
@KonstanceH KonstanceH changed the title 20653 Mobile Home ShipmentCard destination KICKBACK 20653 Mobile Home ShipmentCard destination Kickback Sep 11, 2024
@KonstanceH KonstanceH marked this pull request as ready for review September 11, 2024 15:02
@KonstanceH KonstanceH requested a review from a team as a code owner September 11, 2024 15:02
@KonstanceH KonstanceH marked this pull request as draft September 11, 2024 15:03
@KonstanceH KonstanceH removed the request for review from a team September 11, 2024 15:03
@KonstanceH KonstanceH marked this pull request as ready for review September 11, 2024 15:04
Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽 sorry for slow review

@KonstanceH KonstanceH merged commit 7f42c8c into integrationTesting Sep 11, 2024
30 checks passed
@KonstanceH KonstanceH deleted the 20653-ShipmentCard-Kickback-INT branch September 11, 2024 20:01
Copy link
Contributor

@JamesHawks224 JamesHawks224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing: success
code: lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants