-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20616 add mobile shipment customer flows main #13693
20616 add mobile shipment customer flows main #13693
Conversation
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
Looks like I can't merge due to coverage issue. You may have to include tests for mobile home shipment card that you have in this INT PR for B-20653. Or figure out how to bypass this coverage issue. |
Okay I just added in the tests from B-20653 as you suggested hopefully it gets past the coverage tests |
Thanks! Sorry for the confusion but I was actually referring to the Jest test and the link should have directed you to the file |
Ah okay I just pushed up those tests |
Looks like those tests weren't enough to make the coverage fail go away. I guess you have to write tests for some of the listed files in the coverage test? Possibly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MobileHomeShipmentCard.test.jsx has been added to this PR for test coverage. This test file had been added in this PR in INT: 20653
B-20616
Summary
Integration PR: https://github.com/transcom/mymove/pull/13559/files
REBASE INT PR: #13770
Note
RequiredTag has been removed from this PR and will be added in from 19226 Main PR
MobileHomeShipmentCard.test.jsx:
This PR adds a new line check for tests that are going to be added to integration
from this PR: #13767
And also ups the version for client/server test coverage to match that intergration PR as well.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots
Mobile Home added to shipment options
Mobile Home Info Page
Incomplete Mobile Home added to shipment list