Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20616 add mobile shipment customer flows main #13693

Merged
merged 36 commits into from
Oct 9, 2024

Conversation

KonstanceH
Copy link
Contributor

@KonstanceH KonstanceH commented Sep 11, 2024

B-20616

Summary

Integration PR: https://github.com/transcom/mymove/pull/13559/files

REBASE INT PR: #13770

Note
RequiredTag has been removed from this PR and will be added in from 19226 Main PR
MobileHomeShipmentCard.test.jsx:
This PR adds a new line check for tests that are going to be added to integration
from this PR: #13767
And also ups the version for client/server test coverage to match that intergration PR as well.

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Login as a customer
  2. Create a move
  3. Add a mobile home shipment
  4. Confirm the shipment has been added to the list with the right styling
  5. Confirm ability to delete and edit your added mobile home shipment(s).

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

Mobile Home added to shipment options
Screenshot 2024-08-26 at 5 50 06 AM

Mobile Home Info Page
Screenshot 2024-08-26 at 5 50 13 AM

Incomplete Mobile Home added to shipment list
Screenshot 2024-08-27 at 3 32 48 PM

@robot-mymove
Copy link

robot-mymove commented Sep 11, 2024

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information

Generated by 🚫 dangerJS against 629d345

Copy link

github-actions bot commented Sep 11, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
309 → 310 13.45 MB → 13.47 MB (+22.49 kB) +0.16%
Changeset
File Δ Size
src/components/Customer/MobileHomeShipment/MobileHomeShipmentForm/MobileHomeShipmentForm.jsx 🆕 +9.77 kB 0 B → 9.77 kB
src/pages/MyMove/MobileHome/MobileHomeShipmentCreate/MobileHomeShipmentCreate.jsx 🆕 +6.93 kB 0 B → 6.93 kB
src/components/Customer/Review/ShipmentCard/MobileHomeShipmentCard/MobileHomeShipmentCard.jsx 🆕 +5.14 kB 0 B → 5.14 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[8].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[4]!./src/components/Customer/MobileHomeShipment/MobileHomeShipmentForm/MobileHomeShipmentForm.module.scss 🆕 +2.98 kB 0 B → 2.98 kB
src/pages/MyMove/MobileHome/MobileHomeShipmentLocationInfo/MobileHomeShipmentLocationInfo.jsx 🆕 +1.66 kB 0 B → 1.66 kB
src/components/Customer/modals/BoatAndMobileInfoModal/BoatAndMobileInfoModal.jsx 🆕 +1.6 kB 0 B → 1.6 kB
src/components/Customer/MobileHomeShipment/MobileHomeShipmentForm/MobileHomeShipmentForm.module.scss 🆕 +695 B 0 B → 695 B
src/content/shipments.js 📈 +170 B (+20.43%) 832 B → 1002 B
src/components/ShipmentTag/ShipmentTag.module.scss 📈 +45 B (+16.25%) 277 B → 322 B
src/components/Customer/MtoShipmentForm/getShipmentOptions.js 📈 +386 B (+11.26%) 3.35 kB → 3.72 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[8].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[4]!./src/components/ShipmentTag/ShipmentTag.module.scss 📈 +87 B (+11.24%) 774 B → 861 B
src/components/Customer/Review/Summary/Summary.jsx 📈 +1.51 kB (+9.13%) 16.55 kB → 18.06 kB
src/pages/MyMove/CreateOrEditMtoShipment.jsx 📈 +493 B (+7.99%) 6.03 kB → 6.51 kB
src/components/ShipmentList/ShipmentList.module.scss 📈 +84 B (+7.89%) 1.04 kB → 1.12 kB
src/pages/MyMove/SelectShipmentType.jsx 📈 +760 B (+7.59%) 9.78 kB → 10.52 kB
src/components/Office/ShipmentContainer/ShipmentContainer.jsx 📈 +76 B (+6.95%) 1.07 kB → 1.14 kB
src/utils/shipmentInfo.js 📈 +35 B (+4.85%) 722 B → 757 B
src/types/shipment.js 📈 +271 B (+4.19%) 6.31 kB → 6.58 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[8].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[4]!./src/components/ShipmentList/ShipmentList.module.scss 📈 +81 B (+4.08%) 1.94 kB → 2.02 kB
src/components/ShipmentList/ShipmentList.jsx 📈 +265 B (+3.72%) 6.97 kB → 7.22 kB
src/utils/shipments.js 📈 +146 B (+3.41%) 4.18 kB → 4.32 kB
src/constants/shipments.js 📈 +44 B (+2.57%) 1.67 kB → 1.71 kB
src/shared/constants.js 📈 +107 B (+1.97%) 5.29 kB → 5.4 kB
src/scenes/MyMove/index.jsx 📈 +299 B (+1.49%) 19.55 kB → 19.85 kB
src/constants/routes.js 📈 +91 B (+0.99%) 8.95 kB → 9.04 kB
webpack/runtime/get javascript chunk filename 📈 +18 B (+0.78%) 2.26 kB → 2.28 kB
src/components/Customer/MtoShipmentForm/MtoShipmentForm.jsx 📈 +89 B (+0.45%) 19.35 kB → 19.43 kB
src/pages/MyMove/Home/MoveHome.jsx 📈 +42 B (+0.14%) 29.4 kB → 29.44 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[7].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[4]!./src/styles/customer.scss 📈 +153 B (+0.03%) 500.6 kB → 500.75 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[7].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[4]!./src/styles/signinImports.scss 📈 +153 B (+0.03%) 500.5 kB → 500.65 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[7].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[4]!./src/styles/office.scss 📈 +153 B (+0.03%) 500.64 kB → 500.79 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[8].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[4]!./src/components/MoveSearchForm/MoveSearchForm.module.scss 📈 +197 B (+0.03%) 727.78 kB → 727.98 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[8].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[4]!./src/pages/Office/QAECSRMoveSearch/QAECSRMoveSearch.module.scss 📈 +201 B (+0.03%) 745.35 kB → 745.55 kB
css ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[2]!./node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[8].use[3]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[8].use[4]!./src/components/CustomerSearchForm/CustomerSearchForm.module.scss 📈 +205 B (+0.03%) 765.39 kB → 765.59 kB
src/components/MoveSearchForm/MoveSearchForm.module.scss 📈 +86 B (+0.02%) 358.44 kB → 358.52 kB
src/pages/Office/QAECSRMoveSearch/QAECSRMoveSearch.module.scss 📈 +88 B (+0.02%) 368.87 kB → 368.95 kB
src/components/CustomerSearchForm/CustomerSearchForm.module.scss 📈 +90 B (+0.02%) 379.33 kB → 379.42 kB
src/components/Customer/modals/BoatInfoModal/BoatInfoModal.jsx 🔥 -1.38 kB (-100%) 1.38 kB → 0 B
View detailed bundle breakdown

Added

Asset File Size % Changed
static/js/main.fbddf3bd.js 0 B → 786.92 kB (+786.92 kB) -
static/css/2392.91e5222e.chunk.css 0 B → 688.6 kB (+688.6 kB) -
static/css/1810.64a51008.chunk.css 0 B → 664.26 kB (+664.26 kB) -
static/css/885.8a86747d.chunk.css 0 B → 664.04 kB (+664.04 kB) -
static/css/5450.c9aef0b3.chunk.css 0 B → 511.61 kB (+511.61 kB) -
static/css/8810.5784bc8f.chunk.css 0 B → 455.22 kB (+455.22 kB) -
static/css/3710.27b3045b.chunk.css 0 B → 453.89 kB (+453.89 kB) -
static/js/5450.93ba75df.chunk.js 0 B → 265.74 kB (+265.74 kB) -
static/js/1121.0be9b39b.chunk.js 0 B → 109.39 kB (+109.39 kB) -
static/css/1121.93aca785.chunk.css 0 B → 48.99 kB (+48.99 kB) -
static/css/5883.b15c3615.chunk.css 0 B → 45.67 kB (+45.67 kB) -
static/js/4699.f5dcf858.chunk.js 0 B → 37.05 kB (+37.05 kB) -
static/js/5054.21656a5e.chunk.js 0 B → 33.86 kB (+33.86 kB) -
static/js/4987.5b5a4a8c.chunk.js 0 B → 31.73 kB (+31.73 kB) -
static/js/6748.e2cba627.chunk.js 0 B → 28 kB (+28 kB) -
static/js/4637.a80534e9.chunk.js 0 B → 27.83 kB (+27.83 kB) -
static/js/1865.232dd7d6.chunk.js 0 B → 26.89 kB (+26.89 kB) -
static/css/5054.c367f626.chunk.css 0 B → 21.95 kB (+21.95 kB) -
static/js/9611.159ef9c1.chunk.js 0 B → 19.51 kB (+19.51 kB) -
static/css/434.53ced619.chunk.css 0 B → 18.54 kB (+18.54 kB) -
static/js/6350.f12a4d37.chunk.js 0 B → 14.97 kB (+14.97 kB) -
static/js/538.197d4aa1.chunk.js 0 B → 11.32 kB (+11.32 kB) -
static/js/2092.9e37e313.chunk.js 0 B → 874 B (+874 B) -

Removed

Asset File Size % Changed
static/js/main.8031b1e2.js 786.79 kB → 0 B (-786.79 kB) -100%
static/css/2392.7faf9967.chunk.css 688.41 kB → 0 B (-688.41 kB) -100%
static/css/1810.ffc71c01.chunk.css 664.08 kB → 0 B (-664.08 kB) -100%
static/css/885.2bf84084.chunk.css 663.85 kB → 0 B (-663.85 kB) -100%
static/css/2670.f4713f54.chunk.css 508.36 kB → 0 B (-508.36 kB) -100%
static/css/8810.9f7c01c4.chunk.css 455.07 kB → 0 B (-455.07 kB) -100%
static/css/3710.41229933.chunk.css 453.75 kB → 0 B (-453.75 kB) -100%
static/js/2670.b71da37b.chunk.js 250.57 kB → 0 B (-250.57 kB) -100%
static/js/1121.b45aacbd.chunk.js 109.19 kB → 0 B (-109.19 kB) -100%
static/css/1121.c8d571ad.chunk.css 48.91 kB → 0 B (-48.91 kB) -100%
static/css/5883.d6fc78fd.chunk.css 45.59 kB → 0 B (-45.59 kB) -100%
static/js/4699.1fc98858.chunk.js 37 kB → 0 B (-37 kB) -100%
static/js/5054.465452a3.chunk.js 33.57 kB → 0 B (-33.57 kB) -100%
static/js/4987.e7ef9504.chunk.js 31.5 kB → 0 B (-31.5 kB) -100%
static/js/6748.6534a8d3.chunk.js 27.86 kB → 0 B (-27.86 kB) -100%
static/js/4637.09d84a96.chunk.js 27.68 kB → 0 B (-27.68 kB) -100%
static/js/1865.3a65b2a4.chunk.js 26.81 kB → 0 B (-26.81 kB) -100%
static/css/5054.9f5d3cc7.chunk.css 21.78 kB → 0 B (-21.78 kB) -100%
static/js/9611.f94e99db.chunk.js 19.12 kB → 0 B (-19.12 kB) -100%
static/css/434.c5925d71.chunk.css 18.45 kB → 0 B (-18.45 kB) -100%
static/js/6350.1df25753.chunk.js 14.88 kB → 0 B (-14.88 kB) -100%
static/js/538.6fe9604a.chunk.js 11.28 kB → 0 B (-11.28 kB) -100%

Bigger

Asset File Size % Changed
asset-manifest.json 41.57 kB → 41.72 kB (+152 B) +0.36%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/8946.a8964a6c.chunk.js 1.38 MB 0%
static/js/9043.1e83935c.chunk.js 861.86 kB 0%
static/media/hero.bf01157b9686e90e34dd.png 609.24 kB 0%
static/css/4987.47d4c67a.chunk.css 422.99 kB 0%
static/js/2548.c31aa081.chunk.js 334.66 kB 0%
static/js/2271.af4d7477.chunk.js 154.5 kB 0%
static/js/6637.62bb3910.chunk.js 113.33 kB 0%
static/js/4833.0c49caf9.chunk.js 106.66 kB 0%
static/js/5883.18cf763f.chunk.js 101.02 kB 0%
static/js/7764.6284aa1e.chunk.js 89.66 kB 0%
static/media/PublicSans-Regular.af5c059f36e21e13f39f.ttf 78.03 kB 0%
static/media/PublicSans-Light.839012ec5b7d44a46954.ttf 77.91 kB 0%
static/media/PublicSans-Italic.642113a6a2f365350349.ttf 77.7 kB 0%
static/media/PublicSans-Bold.a52885b904d32280b208.ttf 77.61 kB 0%
static/media/PublicSans-LightItalic.49a5ea322c6c3762b921.ttf 77.44 kB 0%
static/media/PublicSans-BoldItalic.cbc51dd94deab4465d42.ttf 77.41 kB 0%
static/media/transcom-emblem.bcb580b55633c358c82d89f4798081c5.svg 65.22 kB 0%
static/js/6854.8ac4d3c6.chunk.js 63.31 kB 0%
static/js/3502.5c1d6e28.chunk.js 60.3 kB 0%
static/js/4690.1d8fce21.chunk.js 59.09 kB 0%
static/js/8234.5a8142f8.chunk.js 58.33 kB 0%
static/js/5811.8f882b6e.chunk.js 54.36 kB 0%
static/media/sourcesanspro-light-webfont.d6f73cf7210d3b5c2fa9.ttf 53.23 kB 0%
static/media/sourcesanspro-regular-webfont.5acfe0d0f69444765ba4.ttf 53.16 kB 0%
static/media/sourcesanspro-bold-webfont.9a76932911f04be25044.ttf 53.07 kB 0%
static/js/5588.cf16a060.chunk.js 52.76 kB 0%
static/js/434.d4f4f706.chunk.js 52.6 kB 0%
static/js/5448.56e637cc.chunk.js 50.96 kB 0%
static/media/Latin-Merriweather-Regular.43dc3080728216519bf0.ttf 48.32 kB 0%
static/media/Latin-Merriweather-Light.30dd683b4fcfe95b030b.ttf 48.01 kB 0%
static/media/Latin-Merriweather-Bold.b87366633b1019e8c63c.ttf 46.12 kB 0%
static/js/447.e1921258.chunk.js 40.04 kB 0%
static/media/PublicSans-BoldItalic.6bb0cb126756efec5fa5.woff 39.72 kB 0%
static/media/PublicSans-Italic.333d9a80b7b3b003b3c5.woff 39.57 kB 0%
static/media/PublicSans-LightItalic.4c86a8eb158c949923dd.woff 39.53 kB 0%
static/media/Latin-Merriweather-BoldItalic.4d74f3bda45f5aba1abf.ttf 39.52 kB 0%
static/media/PublicSans-Light.8460a3397f2ffc7d22d0.woff 39.23 kB 0%
static/media/PublicSans-Regular.f32753567f64c1ddeec8.woff 39.17 kB 0%
static/media/PublicSans-Bold.8c3655e2b925bcad90cd.woff 39.11 kB 0%
static/media/Latin-Merriweather-Italic.b60043e65fa5cbcedb80.ttf 38.55 kB 0%
static/media/Latin-Merriweather-LightItalic.26ebdd3b8f1d039bc3dd.ttf 38.53 kB 0%
static/media/sourcesanspro-lightitalic-webfont.43ea3d39e6aa59fb6f1b.ttf 38.23 kB 0%
static/js/1007.9854892a.chunk.js 38.15 kB 0%
static/media/sourcesanspro-italic-webfont.3efee318468995ac04af.ttf 37.94 kB 0%
static/media/sourcesanspro-bolditalic-webfont.af3dd40e0ac8e2ca50ac.ttf 37.85 kB 0%
static/css/7764.1848defe.chunk.css 37 kB 0%
static/js/1450.674d183e.chunk.js 34.99 kB 0%
static/js/9565.4b44ae3e.chunk.js 33.61 kB 0%
static/media/PublicSans-BoldItalic.effa83ee2a557ae8a57e.woff2 32.43 kB 0%
static/media/PublicSans-Italic.8be0a159b540a60fd93a.woff2 32.26 kB 0%
static/media/PublicSans-LightItalic.475db532b9392ec581c5.woff2 32.14 kB 0%
static/media/PublicSans-Light.4ba4759c3e98938156d7.woff2 31.84 kB 0%
static/media/roboto-mono-v5-latin-300italic.93511dbad22ceb584f03.ttf 31.83 kB 0%
static/media/roboto-mono-v5-latin-700italic.da78bf0b1b435f40ca19.ttf 31.8 kB 0%
static/media/PublicSans-Regular.e86d2642f412b9493b14.woff2 31.79 kB 0%
static/media/PublicSans-Bold.4045385082dfc34c22d7.woff2 31.64 kB 0%
static/media/roboto-mono-v5-latin-italic.4863add4d566a55b6a97.ttf 31.58 kB 0%
static/media/roboto-mono-v5-latin-300.ce3838471d62f8364e12.ttf 31.41 kB 0%
static/media/okta_logo.56ac9bdcdffeda24c715.png 31.3 kB 0%
static/js/1775.9bb5f4a2.chunk.js 31.04 kB 0%
static/media/roboto-mono-v5-latin-700.e57caf7ea634a258a9b2.ttf 30.36 kB 0%
static/media/roboto-mono-v5-latin-regular.215adb34128fcb20668b.ttf 30.32 kB 0%
static/js/9706.4ce51282.chunk.js 30.19 kB 0%
static/js/1377.ce688d32.chunk.js 28.84 kB 0%
static/js/1291.989c6222.chunk.js 28.36 kB 0%
static/media/Latin-Merriweather-Regular.add503b41601df15b97e.woff 26.87 kB 0%
static/media/Latin-Merriweather-Light.7b2a6350fcb212efe521.woff 26.36 kB 0%
static/media/Latin-Merriweather-Bold.b6cbc321678701d773c6.woff 26.26 kB 0%
static/js/9049.b88ec91c.chunk.js 25.87 kB 0%
static/media/sourcesanspro-regular-webfont.c4e25ab10baa365dfc66.woff 25.53 kB 0%
static/media/sourcesanspro-bold-webfont.e7e051e1bc64fa899317.woff 25.43 kB 0%
static/media/sourcesanspro-light-webfont.70e7d719e258c9a7e68b.woff 25.35 kB 0%
static/js/793.6915bcc5.chunk.js 24.74 kB 0%
static/js/2923.5ae1fb30.chunk.js 24.52 kB 0%
static/css/1865.6b153766.chunk.css 24.46 kB 0%
static/js/6061.a618108e.chunk.js 24.42 kB 0%
static/js/4730.b94663b3.chunk.js 24.11 kB 0%
static/media/Latin-Merriweather-BoldItalic.a0bcf832ed51501c237c.woff 23.89 kB 0%
static/media/Latin-Merriweather-Italic.80d8a9aff0d8bdeb966d.woff 23.59 kB 0%
static/media/Latin-Merriweather-LightItalic.8a239a410a47b6192e05.woff 23.25 kB 0%
static/js/1810.c97e322e.chunk.js 22.54 kB 0%
static/js/7979.fb8a69d3.chunk.js 22.16 kB 0%
static/js/7888.bb5bb757.chunk.js 21.72 kB 0%
static/css/4637.a9876254.chunk.css 21.41 kB 0%
static/css/9706.96d27cc3.chunk.css 21.22 kB 0%
static/media/Latin-Merriweather-Regular.a30c1b8fcb759e9fe728.woff2 21.18 kB 0%
static/js/4136.2468245e.chunk.js 20.96 kB 0%
static/media/Latin-Merriweather-Bold.9caa42f21e4ae090b755.woff2 20.81 kB 0%
static/media/Latin-Merriweather-Light.f347d9834a5feacbcefb.woff2 20.76 kB 0%
static/media/roboto-mono-v5-latin-700italic.0a6791447401e0ebd70d.woff 20.64 kB 0%
static/media/roboto-mono-v5-latin-italic.756750acefdb77704c08.woff 20.6 kB 0%
static/media/roboto-mono-v5-latin-300italic.1b8d46dae0a077f999ae.woff 20.56 kB 0%
static/js/9409.771876eb.chunk.js 20.38 kB 0%
static/js/1208.7767a0a8.chunk.js 20.29 kB 0%
static/css/2271.643cfb33.chunk.css 20.08 kB 0%
static/media/sourcesanspro-regular-webfont.e7bccfa631a0017f31da.woff2 20.06 kB 0%
static/media/sourcesanspro-light-webfont.e5f1a42e1c2b97e25876.woff2 19.93 kB 0%
static/media/sourcesanspro-bold-webfont.4a1efbe82eaa84ff89ed.woff2 19.89 kB 0%
static/media/sourcesanspro-lightitalic-webfont.455d120362f79aa219d4.woff 19.78 kB 0%
static/media/sourcesanspro-italic-webfont.0aaeabbaba3845331078.woff 19.73 kB 0%
static/media/sourcesanspro-bolditalic-webfont.73021f1aabd43f50e16a.woff 19.69 kB 0%
static/media/roboto-mono-v5-latin-300.92dd8f0ccfaebc33f817.woff 19.42 kB 0%
static/css/6061.d24ddb08.chunk.css 19.32 kB 0%
static/media/roboto-mono-v5-latin-regular.a3246d29b40a8b0da142.woff 19.12 kB 0%
static/media/Latin-Merriweather-BoldItalic.dc8b76b44a8a6e5fad1c.woff2 19.11 kB 0%
static/media/roboto-mono-v5-latin-700.d85b43c39f4620dfa5b4.woff 19.11 kB 0%
static/media/Latin-Merriweather-Italic.c63d4066b0f133fc519f.woff2 18.8 kB 0%
static/media/Latin-Merriweather-LightItalic.506121dad559538d44ed.woff2 18.53 kB 0%
static/media/smart-card.c810117aa96a9adbd31b.png 18.39 kB 0%
static/js/9740.2313e1fe.chunk.js 18.37 kB 0%
static/js/551.203c8e2e.chunk.js 18.32 kB 0%
static/media/roboto-mono-v5-latin-300italic.09cc62a8fbd32c8b2812.woff2 16.93 kB 0%
static/media/roboto-mono-v5-latin-700italic.5a8f743549cc6cef9a00.woff2 16.93 kB 0%
static/media/sad-computer.b62f031230f84d7db1b1.png 16.92 kB 0%
static/media/roboto-mono-v5-latin-italic.087069a9f454e2581ed6.woff2 16.91 kB 0%
static/js/4417.c9d82412.chunk.js 16.41 kB 0%
static/css/1775.b9398533.chunk.css 16.22 kB 0%
static/js/9875.3c57d15e.chunk.js 16.13 kB 0%
static/media/sourcesanspro-bolditalic-webfont.ef69f0d737406260319a.woff2 16.03 kB 0%
static/media/roboto-mono-v5-latin-300.316b1352cc4ab2054de6.woff2 16 kB 0%
static/media/sourcesanspro-italic-webfont.c6c9fd228e87eefaf1d4.woff2 15.99 kB 0%
static/media/sourcesanspro-lightitalic-webfont.9c5bf2190b2471c2f22b.woff2 15.93 kB 0%
static/media/roboto-mono-v5-latin-regular.f1dc10a756c2c544588b.woff2 15.65 kB 0%
static/media/roboto-mono-v5-latin-700.936869ba46988c238748.woff2 15.58 kB 0%
static/js/2392.6d5fd27f.chunk.js 15.43 kB 0%
static/js/8693.5f3737e0.chunk.js 15.38 kB 0%
static/js/2680.ce715e10.chunk.js 15.16 kB 0%
static/js/4573.b9766c7c.chunk.js 15.03 kB 0%
static/js/7119.93907677.chunk.js 14.87 kB 0%
static/js/4272.8a2b8c06.chunk.js 14.7 kB 0%
static/js/6411.bb78f854.chunk.js 14.59 kB 0%
static/js/7816.d9921904.chunk.js 14.18 kB 0%
static/js/6696.11739307.chunk.js 13.91 kB 0%
static/js/5151.d0468457.chunk.js 13.73 kB 0%
static/css/7979.4b67dd93.chunk.css 13.44 kB 0%
static/js/5325.c353b468.chunk.js 13.42 kB 0%
static/css/4730.794d45a9.chunk.css 13.36 kB 0%
static/js/7822.33525771.chunk.js 13.33 kB 0%
static/css/7119.133a8aaf.chunk.css 13.28 kB 0%
static/css/1208.02edb420.chunk.css 12.99 kB 0%
static/js/5426.9af1f789.chunk.js 12.89 kB 0%
static/css/1007.60c30fb0.chunk.css 12.17 kB 0%
static/css/9049.60c30fb0.chunk.css 12.17 kB 0%
static/css/6767.7b91635f.chunk.css 12.12 kB 0%
static/css/1255.779d23d6.chunk.css 11.92 kB 0%
static/css/4371.779d23d6.chunk.css 11.92 kB 0%
static/css/6752.779d23d6.chunk.css 11.92 kB 0%
static/css/6931.ee119d21.chunk.css 11.82 kB 0%
static/css/3933.0d60e105.chunk.css 11.81 kB 0%
static/js/3665.5614cae8.chunk.js 11.7 kB 0%
static/css/4272.60e2ded5.chunk.css 11.51 kB 0%
static/js/9414.dd4a5b8f.chunk.js 11.5 kB 0%
static/css/9565.aea20b90.chunk.css 11.5 kB 0%
static/js/7104.cf779a68.chunk.js 11.33 kB 0%
static/js/8797.061c0b48.chunk.js 11.07 kB 0%
static/css/1291.cb6eaaf4.chunk.css 10.95 kB 0%
static/js/9284.79678e27.chunk.js 10.84 kB 0%
static/js/8960.89b793f5.chunk.js 10.66 kB 0%
static/js/9692.360ae775.chunk.js 10.53 kB 0%
static/js/9802.61456f36.chunk.js 10.5 kB 0%
static/js/5091.7c4f6ef7.chunk.js 10.42 kB 0%
static/js/8167.5d886339.chunk.js 10.02 kB 0%
static/js/3933.979f9938.chunk.js 9.75 kB 0%
static/js/7612.47ba4519.chunk.js 9.74 kB 0%
static/css/1377.2539b5da.chunk.css 9.55 kB 0%
static/js/4266.e4c4be7a.chunk.js 9.51 kB 0%
static/js/6462.21d5c9b4.chunk.js 9.44 kB 0%
static/js/4371.f2edf2ba.chunk.js 9.26 kB 0%
static/js/4098.a6f4266d.chunk.js 9.24 kB 0%
static/css/4417.3ff0b4e7.chunk.css 9.03 kB 0%
static/css/7822.3258d177.chunk.css 9.02 kB 0%
static/js/1761.6a3b5b3b.chunk.js 8.97 kB 0%
static/js/6536.08a3a103.chunk.js 8.88 kB 0%
static/js/5560.53d4adb9.chunk.js 8.75 kB 0%
static/js/6368.56891c0e.chunk.js 8.75 kB 0%
static/js/9739.3b4b2e8d.chunk.js 8.53 kB 0%
static/js/2823.db2a7ff9.chunk.js 8.48 kB 0%
static/css/5811.3f97679d.chunk.css 8.04 kB 0%
static/js/1453.963315ee.chunk.js 8.02 kB 0%
static/css/9284.1af4ac4f.chunk.css 7.99 kB 0%
static/css/4535.7ccb16a6.chunk.css 7.92 kB 0%
static/css/5455.7ccb16a6.chunk.css 7.92 kB 0%
static/css/6951.f4050a15.chunk.css 7.82 kB 0%
static/css/1761.cb680a63.chunk.css 7.72 kB 0%
static/css/3665.7e57832d.chunk.css 7.66 kB 0%
static/css/4573.c9edb210.chunk.css 7.36 kB 0%
static/js/4828.be04f13a.chunk.js 7.18 kB 0%
static/js/885.1909eecd.chunk.js 7.06 kB 0%
static/css/5952.23a390aa.chunk.css 6.73 kB 0%
static/css/8884.23a390aa.chunk.css 6.73 kB 0%
static/css/6462.131dcdd9.chunk.css 6.53 kB 0%
static/js/8552.03edcc34.chunk.js 6 kB 0%
static/js/396.52b27b35.chunk.js 5.48 kB 0%
static/css/8093.c243facd.chunk.css 5.45 kB 0%
static/media/milmove-logo.c977261e059ba42b2b70ba95cfb3d3de.svg 5.4 kB 0%
static/css/1453.3262014d.chunk.css 5.35 kB 0%
static/js/5280.d7d8a314.chunk.js 5.32 kB 0%
static/js/4246.f115f535.chunk.js 5.16 kB 0%
static/css/9692.91ee7ddc.chunk.css 4.75 kB 0%
static/js/2283.d9689df6.chunk.js 4.74 kB 0%
static/js/5952.7813cec6.chunk.js 4.7 kB 0%
static/css/5560.8cd86e2b.chunk.css 4.53 kB 0%
static/js/4772.8e680e13.chunk.js 4.49 kB 0%
static/js/6767.709b5080.chunk.js 4.47 kB 0%
static/css/6368.bbc00861.chunk.css 4.4 kB 0%
static/js/177.f8d948b9.chunk.js 4.12 kB 0%
static/js/1224.0e72db8a.chunk.js 4.11 kB 0%
static/css/7612.7f6e106e.chunk.css 3.94 kB 0%
static/css/8167.849b6a40.chunk.css 3.89 kB 0%
static/css/4098.97493b47.chunk.css 3.84 kB 0%
static/css/2823.3dd5d616.chunk.css 3.8 kB 0%
static/css/9739.3dd5d616.chunk.css 3.8 kB 0%
static/js/8884.29cfe2ac.chunk.js 3.68 kB 0%
static/js/4081.67c244f2.chunk.js 3.3 kB 0%
static/css/5426.c785fdaf.chunk.css 3.27 kB 0%
static/css/2680.26e049de.chunk.css 3.25 kB 0%
static/css/5448.c3cbf8e8.chunk.css 3.14 kB 0%
static/js/6752.3c6533f5.chunk.js 2.95 kB 0%
static/js/1711.921429ec.chunk.js 2.93 kB 0%
static/js/9282.ffd51022.chunk.js 2.78 kB 0%
static/css/9414.1e52fa0b.chunk.css 2.77 kB 0%
static/css/4246.bc5e90af.chunk.css 2.6 kB 0%
static/js/8656.66f15362.chunk.js 2.57 kB 0%
static/css/396.96394823.chunk.css 2.5 kB 0%
static/css/5091.652fa3fa.chunk.css 2.49 kB 0%
static/js/7713.46facec3.chunk.js 2.34 kB 0%
static/js/85.737d973a.chunk.js 2.21 kB 0%
static/css/2178.d45c6948.chunk.css 2.04 kB 0%
static/css/9797.35c45fc7.chunk.css 2.04 kB 0%
static/css/8797.d46112ee.chunk.css 1.99 kB 0%
static/js/1255.4b97e70b.chunk.js 1.97 kB 0%
static/css/1224.6facdf3f.chunk.css 1.96 kB 0%
static/css/7713.7b9e081a.chunk.css 1.88 kB 0%
static/css/85.7b9e081a.chunk.css 1.88 kB 0%
static/js/2178.df77f988.chunk.js 1.79 kB 0%
static/js/9797.2ccadc05.chunk.js 1.78 kB 0%
static/media/loader.10d2d7c0a681e4e825da.svg 1.67 kB 0%
static/js/6951.b4a5488d.chunk.js 1.38 kB 0%
static/css/main.5749796c.css 1.27 kB 0%
static/js/6931.e9d7afb1.chunk.js 1.16 kB 0%
static/media/accept-inversed.91ff05235fdd54954706eab64123a3d5.svg 1.14 kB 0%
static/js/5455.cf0976d7.chunk.js 1.11 kB 0%
static/css/177.b6d7c517.chunk.css 1.03 kB 0%
static/css/9282.ab6699ac.chunk.css 960 B 0%
static/media/file-pdf.51bdb15e1e5b831bcf29.svg 904 B 0%
static/js/4124.f6d79fda.chunk.js 876 B 0%
static/js/2967.2acff7e1.chunk.js 874 B 0%
static/css/2283.f5d3a96b.chunk.css 852 B 0%
static/media/file-word.277ffb94e7a09f8a2d1a.svg 760 B 0%
static/media/file-excel.d002b7e57fe318badf49.svg 658 B 0%
static/css/9875.dc11b7b8.chunk.css 609 B 0%
static/media/correct8-alt.30d16a7a68f9063d3141.svg 607 B 0%
static/css/5280.0d997fb0.chunk.css 601 B 0%
static/media/correct8.eac85396da602db01ea3.svg 600 B 0%
index.html 595 B 0%
static/media/twitter.a8c1622d4e18b18caa167dbe0e31135b.svg 588 B 0%
static/media/file-video.15490fa6d64ebfb4f314.svg 574 B 0%
static/css/8960.8fb0844e.chunk.css 531 B 0%
static/css/4124.0b21f13e.chunk.css 462 B 0%
static/media/navigate_far_before.8c7765f1f2719ccdf3e5.svg 403 B 0%
static/media/navigate_far_next.602e9c473cc76474ac50.svg 402 B 0%
static/media/search.bc2178ae2f929aec5f09.svg 372 B 0%
static/css/7816.a9847399.chunk.css 353 B 0%
static/media/facebook.9d8980817d35c2617cf1ebb5a833369a.svg 346 B 0%
static/media/file.7e80f971a49227f49f7e.svg 283 B 0%
static/media/launch--white.4e75d17dfe08a3d7de03.svg 283 B 0%
static/media/launch.65e057b210ca1e5d086e.svg 268 B 0%
static/media/unfold_more.c42abd3e70207a863184.svg 257 B 0%
static/media/check_circle.afe00fa2d228d8e9212e.svg 255 B 0%
static/media/calendar_today.26e6a18c4fb766a6307e.svg 248 B 0%
static/media/error--white.7f8e755b649a0ca72ce5.svg 246 B 0%
static/media/close.53c9f4b6ba9fca553d1e.svg 239 B 0%
static/media/error.57f310a26aa85a42d2a6.svg 234 B 0%
static/media/info.b15cdce316c440127b62.svg 234 B 0%
static/css/6536.c0be8b5e.chunk.css 227 B 0%
static/media/check--blue-60v.c60440495de32668463f.svg 202 B 0%
static/media/arrow_back.037e7aeb3dbe35a36ea6.svg 198 B 0%
static/media/warning.9fcdc101f630d1fd1e97.svg 188 B 0%
static/media/expand_less.018f82c5d61abf0ebfce.svg 184 B 0%
static/media/navigate_before.f280e5b722fcf18e18a9.svg 184 B 0%
static/media/navigate_next.00940e89d53796e4fc95.svg 184 B 0%
static/media/expand_more.7bdcd63935a4c23e5b72.svg 182 B 0%
static/media/add.0ddb797a0b4996c9f281.svg 173 B 0%
static/media/remove.fb2b121df150d251453a.svg 155 B 0%
static/css/1711.9fa21f2c.chunk.css 133 B 0%
static/css/4828.241dfdc5.chunk.css 133 B 0%

@KonstanceH KonstanceH self-assigned this Sep 11, 2024
@KonstanceH KonstanceH added blocked ByteSize M&Ms Team ByteSized M&Ms MAIN and removed blocked labels Sep 16, 2024
@KonstanceH KonstanceH marked this pull request as ready for review September 19, 2024 21:52
@KonstanceH KonstanceH requested a review from a team as a code owner September 19, 2024 21:52
src/shared/styles/colors.scss Outdated Show resolved Hide resolved
@taeJungCaci
Copy link
Contributor

Looks like I can't merge due to coverage issue. You may have to include tests for mobile home shipment card that you have in this INT PR for B-20653. Or figure out how to bypass this coverage issue.

@KonstanceH
Copy link
Contributor Author

Looks like I can't merge due to coverage issue. You may have to include tests for mobile home shipment card that you have in this INT PR for B-20653. Or figure out how to bypass this coverage issue.

Okay I just added in the tests from B-20653 as you suggested hopefully it gets past the coverage tests

@taeJungCaci
Copy link
Contributor

taeJungCaci commented Sep 24, 2024

Looks like I can't merge due to coverage issue. You may have to include tests for mobile home shipment card that you have in this INT PR for B-20653. Or figure out how to bypass this coverage issue.

Okay I just added in the tests from B-20653 as you suggested hopefully it gets past the coverage tests

Thanks! Sorry for the confusion but I was actually referring to the Jest test and the link should have directed you to the filesrc/components/Customer/Review/ShipmentCard/MobileHomeShipmentCard/MobileHomeshipmentCard.test.jsx because I don't think the playwright test are included in the coverage - not sure. But the jest file probably belongs in this PR anyways for the card component.

@KonstanceH
Copy link
Contributor Author

Looks like I can't merge due to coverage issue. You may have to include tests for mobile home shipment card that you have in this INT PR for B-20653. Or figure out how to bypass this coverage issue.

Okay I just added in the tests from B-20653 as you suggested hopefully it gets past the coverage tests

Thanks! Sorry for the confusion but I was actually referring to the Jest test and the link should have directed you to the filesrc/components/Customer/Review/ShipmentCard/MobileHomeShipmentCard/MobileHomeshipmentCard.test.jsx because I don't think the playwright test are included in the coverage - not sure. But the jest file probably belongs in this PR anyways for the card component.

Ah okay I just pushed up those tests

@taeJungCaci
Copy link
Contributor

taeJungCaci commented Sep 25, 2024

Looks like those tests weren't enough to make the coverage fail go away. I guess you have to write tests for some of the listed files in the coverage test? Possibly pkg/handlers/internalapi/moves.goright? Since the code changes you've made in there are feature flag related the test would need that flag also fyi.

Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MobileHomeShipmentCard.test.jsx has been added to this PR for test coverage. This test file had been added in this PR in INT: 20653

@taeJungCaci taeJungCaci changed the title 20621 add mobile shipment customer flows main 20616 add mobile shipment customer flows main Sep 30, 2024
@WeatherfordAaron WeatherfordAaron merged commit 4642283 into main Oct 9, 2024
42 checks passed
@WeatherfordAaron WeatherfordAaron deleted the 20621-Add-Mobile-Shipment-Customer-Flows-MAIN branch October 9, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms MAIN
Development

Successfully merging this pull request may close these issues.

5 participants