Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN B-20787 & B-20788 & B-20789 - NTS/NTS-Release destination/pickup addresses are set to storage facility address #13733

Merged
merged 13 commits into from
Sep 19, 2024

Conversation

ajlusk
Copy link
Contributor

@ajlusk ajlusk commented Sep 17, 2024

B-20787 & B-20788 & B-20789

INT PR

Summary

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the
  2. Login as a

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@ajlusk ajlusk added Scrummy Bears Scrum Team H MAIN labels Sep 17, 2024
@ajlusk ajlusk self-assigned this Sep 17, 2024
@ajlusk ajlusk changed the title MAIN B-20787 MAIN B-20787 & B-20788 & B-20789 Sep 17, 2024
@ajlusk ajlusk changed the title MAIN B-20787 & B-20788 & B-20789 MAIN B-20787 & B-20788 & B-20789 - NTS/NTS-Release destination/pickup addresses are set to storage facility address Sep 17, 2024
@ajlusk ajlusk marked this pull request as ready for review September 17, 2024 21:26
@ajlusk ajlusk requested a review from a team as a code owner September 17, 2024 21:26
Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as INT

Copy link
Contributor

@MInthavongsay MInthavongsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@r-mettler r-mettler merged commit 30d3079 into main Sep 19, 2024
41 checks passed
@r-mettler r-mettler deleted the B-20787 branch September 19, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants