Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B 20654 main #13748

Merged
merged 6 commits into from
Sep 25, 2024
Merged

B 20654 main #13748

merged 6 commits into from
Sep 25, 2024

Conversation

deandreJones
Copy link
Contributor

@deandreJones deandreJones commented Sep 20, 2024 •
edited
Loading

INT PR

pushing to stg to test the bucket upload

@robot-mymove
Copy link

robot-mymove commented Sep 20, 2024 •
edited
Loading

Warnings
⚠️ Please include a description of your PR changes.

Generated by 🚫 dangerJS against 18d700d

@deandreJones deandreJones marked this pull request as ready for review September 25, 2024 15:19
@deandreJones deandreJones requested a review from a team as a code owner September 25, 2024 15:19
danieljordan-caci
danieljordan-caci approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the only difference is a weird line add in the INT branch on the validations file.

Screenshot 2024-09-25 at 10 50 14 AM

cameroncaci
cameroncaci approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits match

@deandreJones deandreJones merged commit cc2beab into main Sep 25, 2024
41 checks passed
@deandreJones deandreJones deleted the B-20654-main branch September 25, 2024 15:53
@deandreJones
Copy link
Contributor Author

Looks like the only difference is a weird line add in the INT branch on the validations file.

Screenshot 2024-09-25 at 10 50 14 AM

what are you looking at... I don't see that file in my changes

@danieljordan-caci
Copy link
Contributor

Looks like the only difference is a weird line add in the INT branch on the validations file.
Screenshot 2024-09-25 at 10 50 14 AM

what are you looking at... I don't see that file in my changes

It's in your INT

@deandreJones deandreJones mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljordan-caci danieljordan-caci danieljordan-caci approved these changes

@cameroncaci cameroncaci cameroncaci approved these changes

@TevinAdams TevinAdams Awaiting requested review from TevinAdams TevinAdams was automatically assigned from transcom/mountain-movers

@traskowskycaci traskowskycaci Awaiting requested review from traskowskycaci traskowskycaci was automatically assigned from transcom/mountain-movers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deandreJones @robot-mymove @danieljordan-caci @cameroncaci