Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in main test checks #13767

Merged
merged 6 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1497,7 +1497,7 @@ jobs:
#
# The trailing hyphen in restore_cache seems important
# according to the page linked above
- v8-server-tests-coverage-
- v9-server-tests-coverage-
- run:
name: Ensure Test Coverage Increasing
command: |
Expand Down Expand Up @@ -1553,7 +1553,7 @@ jobs:
# Use the BuildNum to update the cache key so that the
# coverage cache is always updated
- save_cache:
key: v7-server-tests-coverage-{{ .BuildNum }}
key: v9-server-tests-coverage-{{ .BuildNum }}
paths:
- ~/transcom/mymove/tmp/baseline-go-coverage
when: always
Expand Down Expand Up @@ -1631,7 +1631,7 @@ jobs:
# The trailing hyphen in restore_cache seems important
# according to the page linked above
keys:
- v6-client-tests-coverage-
- v7-client-tests-coverage-
- run:
name: Ensure Test Coverage Increasing
command: |
Expand Down Expand Up @@ -1683,7 +1683,7 @@ jobs:
# Use the BuildNum to update the cache key so that the
# coverage cache is always updated
- save_cache:
key: v5-client-tests-coverage-{{ .BuildNum }}
key: v7-client-tests-coverage-{{ .BuildNum }}
paths:
- ~/transcom/mymove/tmp/baseline-jest-coverage
when: always
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ describe('MobileHomeShipmentCard component', () => {
it('renders component with all fields', () => {
render(<MobileHomeShipmentCard {...defaultProps} />);

expect(screen.getAllByTestId('ShipmentCardNumber').length).toBe(1);
expect(screen.getByRole('heading', { level: 3 })).toHaveTextContent('Mobile Home 1');
expect(screen.getByText(/^#testMove123-01$/, { selector: 'p' })).toBeInTheDocument();

Expand Down Expand Up @@ -133,6 +134,7 @@ describe('MobileHomeShipmentCard component', () => {
expect(screen.getByTitle('Help about incomplete shipment')).toBeInTheDocument();

await userEvent.click(screen.getByTitle('Help about incomplete shipment'));
expect(screen.getAllByTestId('ShipmentCardNumber').length).toBe(1);

expect(incompleteShipmentProps.onIncompleteClick).toHaveBeenCalledWith(
'Mobile Home 1',
Expand Down