Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21328 int #13831

Merged
merged 10 commits into from
Oct 9, 2024
Merged

B 21328 int #13831

merged 10 commits into from
Oct 9, 2024

Conversation

antgmann
Copy link
Contributor

@antgmann antgmann commented Oct 3, 2024

B-21328

Summary

This backlog is a quick precursor to the main feature work to ensure AC is met exactly by the larger downstream story, B-20972. It simply renames a Review weights button to instead read Review shipment weights

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Access the application as a TIO
  2. Select any move in your queue
  3. Ensure the button in the following screenshot reads "Review shipment weights"
image

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Screenshots

ANDI:
image
image
image

Showing the unrelated element failing color contrast:
image

@antgmann antgmann added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Oct 3, 2024
@antgmann antgmann self-assigned this Oct 3, 2024
@antgmann antgmann marked this pull request as ready for review October 3, 2024 20:02
@antgmann antgmann requested a review from a team as a code owner October 3, 2024 20:02
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Screenshot 2024-10-09 at 10 53 33 AM

@antgmann antgmann merged commit ce8f37e into integrationTesting Oct 9, 2024
30 checks passed
@antgmann antgmann deleted the B-21328-INT branch October 9, 2024 15:52
@antgmann antgmann mentioned this pull request Oct 11, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

3 participants