MAIN B-20627 Fix circleci tests and bump dependency #13913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated method calls for http.server.request_content_length and http.server.response_content_length. These are deprecated and we should be using http.server.request.size and http.server.response.size. Also updated the package dependency for otelhttp:v0.43.0 to otelhttp:v0.55.0.
msaki-caci
added
dependencies
msaki-caci
requested review from
deandreJones,
danieljordan-caci,
brianmanley-caci,
elizabeth-perkins,
samaysofo,
ryan-mchugh and
stevengleason-caci
ryan-mchugh
approved these changes
Oct 15, 2024
Didn't see anything on my end kind of just seemed like a copy and paste according to https://transcom.github.io/mymove-docs/docs/getting-started/development/how-to-create-and-submit-PR |
brianmanley-caci
approved these changes
Oct 15, 2024
deandreJones
approved these changes
Oct 15, 2024
samaysofo
approved these changes
Oct 15, 2024
|
@deandreJones I think everything should be good to go for main. |
deandreJones
deleted the
MAIN-B-20627-Fix-circleci-tests-and-upgrade-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-20627
INTEGRATION PR-#13866
Summary
The package otelhttp:v.0.43.0 is outdated and needs to be bumped up to the latest version otelhttp:v.0.55.0.
Normally this is managed through dependabot automatically but each time dependabot attempted the bump there were test failures in circlci. You can find the trail of failed PRs by going here. The latest results show that the dependency bump was failing one of the automated tests run by circleci,
server_test.It appears that the test is failing due to the use of deprecated methods
http.server.request_content_lengthandhttp.server.response_content_length. OpenTelemetry-Go Contrib removed these in otelhttp:v0.49.0 release. It appears that the new methods that need to be used arehttp.server.request.sizeandhttp.server.response.size.After these tests have been fixed, the package should be able to upgraded in the go.mod file to the latest version otelhttp:v.0.55.0 with all circleci tests passing.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Note
Make sure to make the pull request a draft.
Screenshots