Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT B-21549 #13931

Merged
merged 4 commits into from
Oct 17, 2024
Merged

INT B-21549 #13931

merged 4 commits into from
Oct 17, 2024

Conversation

danieljordan-caci
Copy link
Contributor

@danieljordan-caci danieljordan-caci commented Oct 16, 2024 •
edited
Loading

Agility ticket

Summary

Fixing some silly little spacing errors when shipments are listed out.

Out with the old, in with the new.
Screenshot 2024-10-16 at 10 01 16 AM
Screenshot 2024-10-16 at 10 28 50 AM
Screenshot 2024-10-16 at 10 29 13 AM

With UB
Screenshot 2024-10-16 at 12 48 15 PM

How to test

  1. Access MM as a customer
  2. Create a shipment of each kind
  3. Verify that the spacing is not all ugly and wonky with the shipment IDs

@danieljordan-caci danieljordan-caci self-assigned this Oct 16, 2024
@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Oct 16, 2024
@danieljordan-caci danieljordan-caci marked this pull request as ready for review October 16, 2024 16:47
deandreJones
deandreJones approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@deandreJones deandreJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and in line

@robot-mymove
Copy link

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against 1ea87f0

@danieljordan-caci danieljordan-caci merged commit 7d1c15e into integrationTesting Oct 17, 2024
30 checks passed
@danieljordan-caci danieljordan-caci deleted the INT-B-21549 branch October 17, 2024 13:52
@danieljordan-caci danieljordan-caci mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deandreJones deandreJones deandreJones approved these changes

@TevinAdams TevinAdams TevinAdams approved these changes

@cameroncaci cameroncaci Awaiting requested review from cameroncaci cameroncaci was automatically assigned from transcom/mountain-movers

@traskowskycaci traskowskycaci Awaiting requested review from traskowskycaci traskowskycaci was automatically assigned from transcom/mountain-movers

Assignees

@danieljordan-caci danieljordan-caci

Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danieljordan-caci @robot-mymove @deandreJones @TevinAdams