Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN-B-21509 #13990

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

MAIN-B-21509 #13990

wants to merge 13 commits into from

Conversation

msaki-caci
Copy link
Contributor

Create ports and port_location tables
Make go models for port and port_location
Add migrations to the migration_manifest

Agility ticket

Summary

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the
  2. Login as a

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

Create ports and port_location tables
Make go models for port and port_location
Add migrations to the migration_manifest
Remove POD/POE columns from mto_service_items
Update sql queries
Update models for mto_service_items
Fix POE and POD Location in structs
Change 'belongs_to:ports' to 'belongs_to:port'
Add tests for port and port location
Update mto_service_items_test to include POD and POE
Remove redundant 'unique' query
Add comments for new mto_service_items columns
Add ports to db-truncate script
Mark the columns under Port to 'read only'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant