Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21489 Update schema to accommodate multiple transportation offices #14009

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

r-mettler
Copy link
Contributor

B-21489

INT PR

Summary

This story is part of a series of backlogs to add the ability for an Office user to have multiple Transportation Offices assigned to them. We do this by adding a new DB table populated with the current Office Users list of Transportation Offices and setting a Primary Office flag to true.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Run the DB migration file
  2. Open the DB and verify a new transportation_office_assignments table has been created and has all office_users and their appropriate transportation_id with the primary_office flag set to true for all of them.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@r-mettler r-mettler added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing database labels Oct 24, 2024
@r-mettler r-mettler self-assigned this Oct 24, 2024
@r-mettler r-mettler requested a review from a team as a code owner October 24, 2024 20:45
@r-mettler r-mettler added MAIN and removed INTEGRATION Slated for Integration Testing labels Oct 24, 2024
Copy link
Contributor

@CoryKleinjanCACI CoryKleinjanCACI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches INT.

In order to test migrations properly, I had to populate the database prior to running the migration file. Looks like everything populates properly.

Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants