-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Int b 21509 db add poe and pod #14057
base: integrationTesting
Are you sure you want to change the base?
Conversation
Create ports and port_location tables Make go models for port and port_location Add migrations to the migration_manifest
Remove POD/POE columns from mto_service_items
Update sql queries
Update models for mto_service_items
Fix POE and POD Location in structs
Change 'belongs_to:ports' to 'belongs_to:port'
Add tests for port and port location Update mto_service_items_test to include POD and POE Remove redundant 'unique' query
Add comments for new mto_service_items columns
string(PortTypeB), | ||
} | ||
|
||
type Port struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be marked as read only and add ports to db_truncate script. This will be static data and we will send back an error if Prime sends us port codes that are not in this table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked the columns for read only and added ports to the db_truncate in bf6e2f9
Add ports to db-truncate script Mark the columns under Port to 'read only'
B-21509
Summary
We are adding the
ports
andport_location
tables to the database along with adding the Port of Debarkation (POD) and Port of Embarkation (POE) columns tomto_service_items
.Also added tests for
ports
andport_location
and updatedmto_service_items
tests.Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
make db_dev_reset db_dev_migrate
, though the reset might not be necessary.make server_test
Database
Any new migrations/schema changes: