Int b 21509 db add poe and pod #14057
Open
+710
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create ports and port_location tables Make go models for port and port_location Add migrations to the migration_manifest
Remove POD/POE columns from mto_service_items
Update sql queries
Update models for mto_service_items
Fix POE and POD Location in structs
Change 'belongs_to:ports' to 'belongs_to:port'
Add tests for port and port location Update mto_service_items_test to include POD and POE Remove redundant 'unique' query
Add comments for new mto_service_items columns
msaki-caci
added
INTEGRATION
msaki-caci
requested review from
deandreJones,
danieljordan-caci,
r-mettler,
brianmanley-caci,
begrohmann,
elizabeth-perkins,
samaysofo,
ryan-mchugh and
stevengleason-caci
begrohmann
reviewed
Oct 30, 2024
| string(PortTypeB), | ||
| } | ||
|
|
||
| type Port struct { |
There was a problem hiding this comment.
These should be marked as read only and add ports to db_truncate script. This will be static data and we will send back an error if Prime sends us port codes that are not in this table.
There was a problem hiding this comment.
Marked the columns for read only and added ports to the db_truncate in bf6e2f9
Add ports to db-truncate script Mark the columns under Port to 'read only'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21509
Summary
We are adding the
portsandport_locationtables to the database along with adding the Port of Debarkation (POD) and Port of Embarkation (POE) columns tomto_service_items.Also added tests for
portsandport_locationand updatedmto_service_itemstests.Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
make db_dev_reset db_dev_migrate, though the reset might not be necessary.make server_testDatabase
Any new migrations/schema changes: