-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT B-20928 #14058
Open
danieljordan-caci
wants to merge
13
commits into
integrationTesting
Choose a base branch
from
int-b-20928
base: integrationTesting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
INT B-20928 #14058
+48
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
added
Mountain Movers
Movin' Mountains 1 Sprint at a time
INTEGRATION
Slated for Integration Testing
labels
Oct 30, 2024
danieljordan-caci
requested review from
deandreJones,
TevinAdams,
cameroncaci and
traskowskycaci
October 30, 2024 14:58
lucyluuuu
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not see new vulnerabilities on files changed when scanned locally. Pre-test jobs ran successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
Security wanted us to not use
MD5
hashing, so transitioning toSHA256
for uploads and adding in theCheckSumAlgorithem
when uploading to S3.This also contains code to fix some flaky tests. Idk, man.
How to test
.envrc
and uncommentexport STORAGE_BACKEND=s3
direnv allow
aws-vault exec transcom-gov-dev -- make server_run
transcom-gov-dev
aws-vault login transcom-gov-dev
- this will open the AWS Consoletranscom-gov-dev-app-devlocal-us-gov-west-1
, click itdaniel.jordan_cn
)Object Overview
sectionAdditional checksums
sectionSHA-256
checksumScreenshots