Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21524 adding space #14060

Conversation

KonstanceH
Copy link
Contributor

@KonstanceH KonstanceH commented Oct 30, 2024

B-21524

Summary

Integration PR: #14013
This PR adds a space that was missing between "your PPM incentive (or Actual..."

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

Test non actual expense move

  1. Instead of runnning make server_run run this:
    EMAIL_BACKEND=ses AWS_REGION=us-gov-west-1 aws-vault exec transcom-gov-dev -- make server_run
    and then run make client_run
  2. Create a PPM move
  3. Login as a Service counselor and submit the move details
  4. Confirm added space here "your PPM incentive (or Actual..."

Test actual expense move

  1. Create a PPM move
  2. in the database set its "isActualExpenseReimbursement" to true
  3. Login as a Service counselor and submit the move details
  4. Confirm added space here "your PPM incentive (or Actual..."

Backend

Screenshots

ActualExpenseReimbursement
Screenshot 2024-10-30 at 11 27 26 AM

Not ActualExpenseReimbursement
Screenshot 2024-10-30 at 11 14 46 AM

AC Email:
Screenshot 2024-10-29 at 8 46 38 AM

Email #2 - Your counselor has approved your move details update - 2 Oct 24 (1).docx

@KonstanceH KonstanceH self-assigned this Oct 30, 2024
@KonstanceH KonstanceH added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Oct 30, 2024
@KonstanceH KonstanceH marked this pull request as ready for review October 30, 2024 16:36
@KonstanceH KonstanceH changed the title adding space B-21524 adding space Oct 30, 2024
Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽

@KonstanceH KonstanceH merged commit ea3fdcd into integrationTesting Oct 30, 2024
30 checks passed
@KonstanceH KonstanceH deleted the B-21524-Update-Counselor-Approved-Email-KICKBACK-INT branch October 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

3 participants