Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Add a option to disable Refresh of Tables Primary Keys #301

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mathd
Copy link

@mathd mathd commented Aug 9, 2022

Problem

When we are doing a refresh of primary keys for all tables, PipelineWise that 4 times longer to execute even if I don't make any change the the schema or tables.

Proposed changes

Add a option in the config file to disable the refresh of tables primary keys. With default to False to make sure not to disturbed existing configuration.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant