Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Fix compatibility issues with snowflake-connector-python OpenSSL and oscrypto #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dluftspring
Copy link

@dluftspring dluftspring commented Mar 14, 2024

Problem

Problem is outlined here

Proposed changes

By pinning the version in the target we avoid the possibility that people unexpectedly enter dependency hell. Trying to do a fresh install of OpenSSL is a lot harder than patching the version of a python library

Types of changes

What types of changes does your code introduce to PipelineWise?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@dluftspring dluftspring changed the title Pin oscrypto to pre-release patch commit Fix compatibility issues with snowflake-connector-python OpenSSL and oscrypto Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant