Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 does not know the
cmp
function.Apparently that was still part of this repo, i.e. in line 347 of
sourcefinder/utility/coordinates.py
, in theangsep
function.In the tkp repo this has been corrected.
The solution, as usual, comes from SO: simply add a
cmp
function.This also fixes #6 in the sense that, using this branch, an AARTFAAC image could be correctly processed with a "Numpy version greater than 1.10.x".
1.24.1 in this case.