Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distorted outputs by using correct padding when reading/writing gl image data. #29

Merged
merged 1 commit into from
Feb 23, 2019

Conversation

jviney
Copy link
Contributor

@jviney jviney commented Oct 3, 2018

Fixes #7.

@transitive-bullshit
Copy link
Owner

This looks perfect @jviney -- thank you so much! 👍

Give me a day or so to test locally.

Copy link
Owner

@transitive-bullshit transitive-bullshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it's taken me so long to merge this -- thank you so much!!

@transitive-bullshit transitive-bullshit merged commit 03e00da into transitive-bullshit:master Feb 23, 2019
@CoreTechie
Copy link

CoreTechie commented Mar 13, 2019

Does this also fixes Issue #28 ? Issue with all resolutions (including 1920 x 1080) having 16:9 aspect ratio ? In 1920 x 1080, it seems the frames appears to be cropped at both the top and right edges.

@transitive-bullshit
Copy link
Owner

It should @CoreTechie. Please follow-up if you're still experiencing issues.

@CoreTechie
Copy link

This doesn't seem to address the issue of cropping at the top and right edges of the frame of dims 1920 x 1080. A few rows at the top edge and couple of columns on the right edge are getting clipped. Has it something to do with the Magnification or Minification filters while the image data is mapped onto the texture ?

glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);

@CoreTechie
Copy link

Hi Travis (@transitive-bullshit ) - Could you reproduce the problem with 1920 x 1080. What could be the possible causes for the cross-faded picture being shrunk. Also it seems the picture is slightly vertically shifted down including clipping on both top and right edges. Thanks !

@yukesh0505
Copy link

Hi, I have the same bug. For some aspect ratio, rendered video didn't produce actual transition some funky transition occurs. please give me some suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rendering bug for some aspect ratios
4 participants