Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates sharp to latest version #10

Merged

Conversation

halas
Copy link
Contributor

@halas halas commented Jul 12, 2024

lqip-modrn depends on version of sharp with high severity vulnerability ( GHSA-54xq-cgqr-rpm3)

This PR updates sharp version and as apparently updtes sharp leads to slightly different result, updates test snapshots.

halas added 2 commits July 12, 2024 23:37
Changed probably because of sharp version change
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/safer-buffer@2.1.2 None 0 42.3 kB chalker
npm/sharp@0.33.4 environment Transitive: eval, filesystem, shell +28 181 MB lovell

🚮 Removed packages: npm/detect-libc@2.0.1, npm/end-of-stream@1.4.4, npm/mkdirp-classic@0.5.3, npm/sharp@0.31.2, npm/simple-get@4.0.1, npm/tar-fs@2.1.1, npm/tar-stream@2.2.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/sharp@0.33.4
  • Install script: install
  • Source: node install/check
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/sharp@0.33.4

@halas halas marked this pull request as ready for review July 12, 2024 21:46
@transitive-bullshit transitive-bullshit merged commit 54c3b79 into transitive-bullshit:master Jul 13, 2024
1 of 2 checks passed
@transitive-bullshit
Copy link
Owner

Thanks! 🙏

@halas halas deleted the Update-sharp-to-latest branch July 13, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants