Skip to content

Commit

Permalink
Implement more of @mifi's feedfback
Browse files Browse the repository at this point in the history
  • Loading branch information
kvz committed Mar 22, 2021
1 parent d110589 commit 1f7c2b3
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,22 +124,19 @@ module.exports = {
},
],

// It's true that we'd generally like to use object.property,
// Evgenia: It's true that we'd generally like to use object.property,
// but this.state.formState is usually better read when we read
// this.state.formState['property'].
'camelcase': ['off'],
'dot-notation': ['off'],
'no-fallthrough': ['off'],
'no-multi-spaces': ['off'],
'no-multi-str': ['off'],
'node/no-path-concat': ['off'],
'react/prop-types': ['off'],

// perhaps enable in future release?
'no-cond-assign': ['off'], // <-- can be useful with if ((m = x.match())) { // handle matches }
'no-template-curly-in-string': ['off'],
'prefer-import/prefer-import-over-require': ['off'],
'react/jsx-closing-tag-location': ['off'], // <-- autofix conflicts with react/jsx-indent, causing ugly code fix in e.g. langEn.js

// rules i disagree with or had problems with
////////////////////////////////////////////////////////////
Expand Down

0 comments on commit 1f7c2b3

Please sign in to comment.