Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add no-useless-iife #24

Merged
merged 4 commits into from
Oct 2, 2023
Merged

add no-useless-iife #24

merged 4 commits into from
Oct 2, 2023

Conversation

mifi
Copy link
Collaborator

@mifi mifi commented Jul 14, 2023 •
edited
Loading

aduh95
aduh95 reviewed Jul 20, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
mifi and others added 2 commits July 20, 2023 21:24
@mifi @aduh95
Update package.json
0a28b92 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@mifi
run yarn
a3225ed
@mifi
Copy link
Collaborator Author

mifi commented Jul 20, 2023

shall we release a new version of eslint-config-transloadit with no-useless-iife, wdyt? major/minor?

@aduh95
Copy link
Contributor

aduh95 commented Jul 28, 2023

I think if we're adding a new peer dependency, that's somewhat major because it would break consumers updating to that version.

@aduh95
Copy link
Contributor

aduh95 commented Sep 29, 2023 •
edited
Loading

Can we merge this, and release a new major? Do we want to push more major changes while we're at it? Maybe remove the dependency on Jest?

@mifi
Copy link
Collaborator Author

mifi commented Oct 2, 2023

eslint-plugin-jest was added in 9648419 - not sure why. I think we can remove it.

@mifi mifi merged commit 13c6670 into main Oct 2, 2023
@mifi mifi deleted the no-useless-iife branch October 2, 2023 06:54
@mifi
Copy link
Collaborator Author

mifi commented Oct 2, 2023

@kvz wdyt shall I do a major release of eslint-config-transloadit? I will upgrade all deps too

mifi added a commit that referenced this pull request Oct 2, 2023
@mifi
remove eslint-plugin-jest
ff2ea2f 
see #24 (comment)
@mifi mifi mentioned this pull request Oct 2, 2023
Merged
@kvz
Copy link
Member

kvz commented Oct 2, 2023

That sounds good. We could check in the consuming repos which rules turned out to be too much to fix them over the years, leading to unanimous disables, and maybe exclude them from the next major? Or at least discuss them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mifi @aduh95 @kvz