Throw proper error when passing a non-readable stream

Fixes #92

package.json

@@ -37,6 +37,7 @@
     "localtunnel": "^2.0.0",
     "nock": "^13.0.5",
     "p-retry": "^4.2.0",
+    "request": "^2.88.2",
     "temp": "^0.9.1",
     "tsd": "^0.14.0"
   },

src/Transloadit.js

@@ -127,10 +127,18 @@ class TransloaditClient {
     }
 
     // Convert uploads to streams
-    const streamsMap = fromPairs(Object.entries(uploads).map(([label, value]) => [
-      label,
-      isStream.readable(value) ? value : intoStream(value),
-    ]))
+    const streamsMap = fromPairs(Object.entries(uploads).map(([label, value]) => {
+      const isReadable = isStream.readable(value)
+      if (!isReadable && isStream(value)) {
+        // https://github.com/transloadit/node-sdk/issues/92
+        throw new Error(`Upload named "${label}" is not a Readable stream`)
+      }
+
+      return [
+        label,
+        isStream.readable(value) ? value : intoStream(value),
+      ]
+    }))
 
     // Wrap in object structure (so we can know if it's a pathless stream or not)
     const allStreamsMap = fromPairs(Object.entries(streamsMap).map(([label, stream]) => [label, { stream }]))

test/integration/__tests__/live-api.js

@@ -15,6 +15,7 @@ const { pipeline: streamPipeline } = require('stream')
 const got = require('got')
 const pipeline = promisify(streamPipeline)
 const intoStream = require('into-stream')
+const request = require('request')
 
 const Transloadit = require('../../../src/Transloadit')
 
@@ -260,6 +261,15 @@ describe('API integration', function () {
       })
     })
 
+    it('should throw a proper error for request stream', async () => {
+      const client = createClient()
+
+      const req = request(genericImg)
+
+      const promise = client.createAssembly({ uploads: { file: req } })
+      await expect(promise).rejects.toThrow(expect.objectContaining({ message: 'Upload named "file" is not a Readable stream' }))
+    })
+
     async function testUploadProgress (isResumable) {
       const client = createClient()