Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default to SHA-384 for signature authentication #174

Merged
merged 2 commits into from
Mar 1, 2024
Merged

feat: default to SHA-384 for signature authentication #174

merged 2 commits into from
Mar 1, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 26, 2024 •
edited
Loading

SHA-1 is not as secure as SHA-384.

@Acconut
Copy link
Member

Acconut commented Feb 26, 2024

Should we add an option to configure the used algorithm? Are there cases in which users want to stick with SHA-1?

@mifi
Copy link
Collaborator

mifi commented Feb 28, 2024

I assume you meant to say that sha384 is more secure than sha1. If all Transloadit servers support sha384 and it's not that much more expensive to calculate and verify, then I don't see any reason why we'd need an option

@mifi mifi merged commit c85fd7d into main Mar 1, 2024
3 checks passed
@mifi mifi deleted the sha384-signatures branch March 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acconut Acconut Acconut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @Acconut @mifi