Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to vitest #176

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Switch to vitest #176

merged 7 commits into from
Aug 22, 2024

Conversation

remcohaszing
Copy link
Member

This replaces Jest as a test runner with Vitest. Jest has too many issues resolving modules and running TypeScript.

The tests were renamed to match Vitest’s default test pattern.

The ESLint configuration was adjusted a bit to match the new setup as well.

This replaces Jest as a test runner with Vitest. Jest has too many
issues resolving modules and running TypeScript.

The tests were renamed to match Vitest’s default test pattern.

The ESLint configuration was adjusted a bit to match the new setup as
well.
@remcohaszing
Copy link
Member Author

Oh no, apparently Vitest requires Node.js 18 or greater, but this project supports Node.js 14. Do we want to test against older Node.js versions?

I would prefer to even use node:test instead of Vitest, but the current tests rely on module mocking.

@remcohaszing remcohaszing mentioned this pull request Aug 13, 2024
1 task
@remcohaszing remcohaszing requested a review from mifi August 19, 2024 15:39
Copy link
Collaborator

@mifi mifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as long as you tested locally (live-api) and see that the number of tests are the same as before, and coverage still works

src/Transloadit.js Show resolved Hide resolved
test/integration/live-api.test.js Show resolved Hide resolved
@remcohaszing remcohaszing merged commit 0868ca5 into main Aug 22, 2024
3 checks passed
@remcohaszing remcohaszing deleted the vitest branch August 22, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants