Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project eslint standardjs compatible #7

Merged
merged 10 commits into from
Dec 3, 2016
Merged

Make project eslint standardjs compatible #7

merged 10 commits into from
Dec 3, 2016

Conversation

kvz
Copy link
Member

@kvz kvz commented Dec 1, 2016

All of this was fixed automatically, these are the linting warnings remaining:


/Users/kvz/code/transloadify/src/assemblies-create.js
  285:26  error  Arrow function should not return assignment  no-return-assign

/Users/kvz/code/transloadify/src/assemblies.js
  11:13  error  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  73:17  error  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  73:24  error  Object properties must go on a new line if they aren't all on the same line  object-property-newline

/Users/kvz/code/transloadify/src/cli.js
    1:8   error  'fs' is defined but never used                       no-unused-vars
   57:7   error  'modesSpecified' is assigned a value but never used  no-unused-vars
  112:29  error  Unexpected use of comma operator                     no-sequences
  118:30  error  Expected '!==' and instead saw '!='                  eqeqeq
  195:10  error  'atLeastOneOfOption' is defined but never used       no-unused-vars

/Users/kvz/code/transloadify/src/notifications.js
  2:12  error  Identifier 'assembly_id' is not in camel case  camelcase

/Users/kvz/code/transloadify/src/Parser.js
  24:33  error  Irregular whitespace not allowed  no-irregular-whitespace

/Users/kvz/code/transloadify/src/templates.js
   5:38  error  Expected error to be handled                                                 handle-callback-err
  66:12  error  Object properties must go on a new line if they aren't all on the same line  object-property-newline
  66:18  error  Object properties must go on a new line if they aren't all on the same line  object-property-newline

/Users/kvz/code/transloadify/test/cli.js
  374:29  error  Expected '===' and instead saw '=='  eqeqeq

@adrusi would you be able to fix these manually? Afterwards we can add npm run lint to Travis, so we get failures if someone submits a PR that does not adhere to the coding conventions (also part of this PR).

As a friendly tip, if you can get support for eslint & standard in your editor, that makes sure that these rules don't get annoying much, as you'll get guided to adhere while you're still in the zone.

To check locally for remaining issues, run: npm run lint also.

@kvz kvz merged commit 3327985 into master Dec 3, 2016
@kvz kvz deleted the standard-linting branch December 3, 2016 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants