Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETA with leading zeros #137

Merged
merged 2 commits into from
Dec 12, 2016
Merged

ETA with leading zeros #137

merged 2 commits into from
Dec 12, 2016

Conversation

oliverpool
Copy link
Contributor

This is related to #65: the time string is making some "jumps" when it passes from 1m 10s to 1m 9s.

This PR adds a leading 0 to all "trailing" units:
1m 9s becomes 1m 09s, but 9s stays as it is

@arturi
Copy link
Contributor

arturi commented Dec 12, 2016

Thanks! Do you think we should do the same with speed?

@arturi arturi merged commit 95d1ed1 into transloadit:master Dec 12, 2016
@oliverpool oliverpool deleted the eta-with-leading-zeros branch December 13, 2016 07:19
@oliverpool
Copy link
Contributor Author

Thanks! Do you think we should do the same with speed?

Regarding the upload speed "string jumps", the package prettier-bytes could be used instead of pretty-bytes.

(prettier-bytes) augment pretty-bytes to make the output a little more readable (and a little less precise)

@arturi
Copy link
Contributor

arturi commented Dec 13, 2016

Regarding the upload speed "string jumps", the package prettier-bytes could be used instead of pretty-bytes.

Probably yes, sorry I missed your comment on that. I tried using it and had to revert because of IE10 support — the other package used something that was incompatible. Will look into this again.

@oliverpool
Copy link
Contributor Author

I tried using it and had to revert because of IE10 support

The 2 codes don't seem to different from one another: prettier-bytes, pretty-bytes

@arturi
Copy link
Contributor

arturi commented Dec 14, 2016

It’s the Number.isNaN here, it’s ES6: http://caniuse.com/#search=isnan

@oliverpool
Copy link
Contributor Author

Number.isFinite from pretty-bytes is also unsupported by IE11: http://caniuse.com/#search=isFinite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants