core: Only catch errors from onBeforeUpload
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this code would treat any error at all as an `onBeforeUpload` error, and show the informer. We also lost the stack trace for errors because `err` is stringified in the handler. This is correct for `onBeforeUpload` rejections, since they are string reasons, but not for other errors. Now only actual `onBeforeUpload` errors are handled that way, and fatal upload errors end up in the StatusBar like before and in the console, with a stack trace.
|
Cool! What about |
62c2645, but for `onBeforeFileAdded`.
|
Good catch, I forgot about that :') Thanks! Addressed in b763e15 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this code would treat any error at all as an
onBeforeUploaderror, and show the informer. We also lost the stack trace for errors
because
erris stringified in the handler. This is correct foronBeforeUploadrejections, since they are string reasons, but not forother errors.
Now only actual
onBeforeUploaderrors are handled that way, and fatalupload errors end up in the StatusBar like before and in the console,
with a stack trace.