Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock node-js version on ci #4606

Merged
merged 1 commit into from
Jul 31, 2023
Merged

lock node-js version on ci #4606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
# todo put back?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth being a little more elaborate here

(I'm assuming you're testing ci, just a little reminder to change before merging)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm trying to workaround a bug in node.js that got triggered here: f639a67

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meaning i'm trying to "fix" ci on main. not sure if 18.x, 20.x is the right way to go. I mean we use yarn.lock for all npm packages, so why shouldn't we lock node.js versions too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like to use volta as node version manager - it can lock the node and yarn/npm versions in package.json

Makes a lot of sense...

node-version: [16.x, 18.16.0, 20.4.0]
steps:
- name: Checkout sources
uses: actions/checkout@v3
Expand Down