Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in French translation #1479

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

vlec-be
Copy link
Contributor

@vlec-be vlec-be commented Oct 2, 2024

Summary by CodeRabbit

  • New Features
    • Improved French translations for various user interface strings, enhancing clarity and grammatical accuracy.
  • Bug Fixes
    • Corrected typographical errors in translation phrases.
  • Documentation
    • Added new phrases related to application functionality for better user guidance.

Copy link

what-the-diff bot commented Oct 2, 2024

PR Summary

  • Updated French Translation
    The French translation of the phrase "Check for updates" has been corrected. Previously, it was "Vérifier les mises à jours", and it is now "Vérifier les mises à jour". This ensures that the phrase is grammatically correct in French and makes it easier for French speaking users to understand.

@PeterDaveHello
Copy link
Member

@coderabbitai review

Copy link

coderabbitai bot commented Oct 2, 2024

@PeterDaveHello: I will review the changes.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

coderabbitai bot commented Oct 2, 2024

Walkthrough

The changes involve updates to the French translation file lang/transgui.fr for a torrent management application. Modifications include corrections to grammatical errors, refinements for improved readability, and the addition of new phrases to enhance the localization of the user interface. Specific phrases were corrected for accuracy, ensuring that all interface elements are contextually appropriate and user-friendly.

Changes

File Change Summary
lang/transgui.fr Updated various user interface strings for grammatical accuracy and clarity, including corrections and new phrases.

Poem

In the land of torrents, where data flows,
A rabbit hops by, as the translation grows.
With phrases polished, and errors set right,
The French now sings sweetly, a delightful sight!
So let’s cheer for the changes, both new and refined,
For a user-friendly journey, perfectly designed! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
lang/transgui.fr (1)

Line range hint 331-331: Incomplete translation detected

The first part of the message "Unable to find path mapping." is not translated to French, while the rest of the message is. This inconsistency could confuse French users.

Consider translating the entire message to French. Here's a suggested translation:

-Unable to find path mapping.~Utilisez les Options de Transmission Remote GUI pour définir la correspondance des chemins
+Impossible de trouver la correspondance des chemins.~Utilisez les Options de Transmission Remote GUI pour définir la correspondance des chemins
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 25df397 and b805ad7.

📒 Files selected for processing (1)
  • lang/transgui.fr (1 hunks)
🔇 Additional comments (5)
lang/transgui.fr (5)

271-271: Grammatical correction approved

The change from "Vérifier les mises à jours" to "Vérifier les mises à jour" is correct. This fixes a common grammatical error in French where "jour" was incorrectly pluralized in the expression "à jour".


Line range hint 282-283: Accurate and natural translation

The French translation accurately conveys the meaning of the English phrase. The use of "comptabilisés vers" for "counted toward" and the translations of "Download queue" and "Upload queue" are appropriate in the context of torrent management.


Line range hint 320-320: New translation added correctly

The newly added French translation for the password prompt is accurate and maintains the politeness of the original English phrase. The placeholder %s is correctly preserved, which is crucial for proper string formatting.


Line range hint 334-334: New translation added with slight modification

The newly added French translation accurately conveys the message about restarting the application. The translation is grammatically correct and uses appropriate terminology.

Note: The French version specifies "Transmission Remote GUI" instead of a generic "the application" as in the English version. This is more specific and may be intentional, but it's worth confirming if this level of specificity is desired across all language files.


Line range hint 1-334: Summary of French language file updates

The changes to the French language file are generally positive, improving grammar, adding new translations, and refining existing ones. Most modifications accurately convey the meaning of the English phrases while maintaining natural French language use.

Key points:

  1. Grammatical correction on line 271 improves the accuracy of the French text.
  2. New translations added are mostly accurate and contextually appropriate.
  3. One instance of an incomplete translation was found on line 331, which should be addressed.
  4. Some translations, like on line 334, use specific application names where the English version is more generic. This may be intentional but should be verified for consistency across language files.

Overall, these updates enhance the French localization of the application, with only minor adjustments needed for full consistency.

@PeterDaveHello
Copy link
Member

@coderabbitai your review looks odd, this PR only revised one line of French translation, not as many as you mentioned.

Copy link

coderabbitai bot commented Oct 2, 2024

Tip

For best results, initiate chat on the files or code changes.

@PeterDaveHello, thank you for pointing this out. I apologize for the incorrect summary. Upon reviewing the changes, I confirm that this PR only revises one line in the French translation file lang/transgui.fr, correcting "Vérifier les mises à jours" to "Vérifier les mises à jour". I'll ensure that future summaries accurately reflect the actual changes.


✏️ Learnings added
Learnt from: PeterDaveHello
URL: https://github.com/transmission-remote-gui/transgui/pull/1479

Timestamp: 2024-10-02T21:11:28.519Z
Learning: When generating AI summaries, ensure they accurately reflect the changes in the PR, especially when only a few lines are changed.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

@PeterDaveHello PeterDaveHello changed the title update french language file Correct typo in French translation Oct 2, 2024
@PeterDaveHello PeterDaveHello merged commit 8854357 into transmission-remote-gui:master Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants