-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct typo in French translation #1479
Conversation
PR Summary
|
@coderabbitai review |
@PeterDaveHello: I will review the changes. ✅ Actions performedReview triggered.
|
WalkthroughThe changes involve updates to the French translation file Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
lang/transgui.fr (1)
Line range hint
331-331
: Incomplete translation detectedThe first part of the message "Unable to find path mapping." is not translated to French, while the rest of the message is. This inconsistency could confuse French users.
Consider translating the entire message to French. Here's a suggested translation:
-Unable to find path mapping.~Utilisez les Options de Transmission Remote GUI pour définir la correspondance des chemins +Impossible de trouver la correspondance des chemins.~Utilisez les Options de Transmission Remote GUI pour définir la correspondance des chemins
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- lang/transgui.fr (1 hunks)
🔇 Additional comments (5)
lang/transgui.fr (5)
271-271
: Grammatical correction approvedThe change from "Vérifier les mises à jours" to "Vérifier les mises à jour" is correct. This fixes a common grammatical error in French where "jour" was incorrectly pluralized in the expression "à jour".
Line range hint
282-283
: Accurate and natural translationThe French translation accurately conveys the meaning of the English phrase. The use of "comptabilisés vers" for "counted toward" and the translations of "Download queue" and "Upload queue" are appropriate in the context of torrent management.
Line range hint
320-320
: New translation added correctlyThe newly added French translation for the password prompt is accurate and maintains the politeness of the original English phrase. The placeholder %s is correctly preserved, which is crucial for proper string formatting.
Line range hint
334-334
: New translation added with slight modificationThe newly added French translation accurately conveys the message about restarting the application. The translation is grammatically correct and uses appropriate terminology.
Note: The French version specifies "Transmission Remote GUI" instead of a generic "the application" as in the English version. This is more specific and may be intentional, but it's worth confirming if this level of specificity is desired across all language files.
Line range hint
1-334
: Summary of French language file updatesThe changes to the French language file are generally positive, improving grammar, adding new translations, and refining existing ones. Most modifications accurately convey the meaning of the English phrases while maintaining natural French language use.
Key points:
- Grammatical correction on line 271 improves the accuracy of the French text.
- New translations added are mostly accurate and contextually appropriate.
- One instance of an incomplete translation was found on line 331, which should be addressed.
- Some translations, like on line 334, use specific application names where the English version is more generic. This may be intentional but should be verified for consistency across language files.
Overall, these updates enhance the French localization of the application, with only minor adjustments needed for full consistency.
@coderabbitai your review looks odd, this PR only revised one line of French translation, not as many as you mentioned. |
Tip For best results, initiate chat on the files or code changes. @PeterDaveHello, thank you for pointing this out. I apologize for the incorrect summary. Upon reviewing the changes, I confirm that this PR only revises one line in the French translation file ✏️ Learnings added
|
8854357
into
transmission-remote-gui:master
Summary by CodeRabbit