Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Apply feedback from consensus call #31

Merged
merged 10 commits into from
Mar 4, 2024
Merged

Apply feedback from consensus call #31

merged 10 commits into from
Mar 4, 2024

Conversation

OR13
Copy link
Member

@OR13 OR13 commented Mar 1, 2024

This pull request addressed comments on the consensus call conducted on the list:

https://mailarchive.ietf.org/arch/msg/spice/TTgOt6qI3CzILzV4i34nLmkmeMc/

@OR13 OR13 marked this pull request as ready for review March 1, 2024 20:05
Copy link
Contributor

@brentzundel brentzundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements, thank you.

charter.md Outdated Show resolved Hide resolved
Copy link

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Great to see SPICE progressing

@mprorock
Copy link

mprorock commented Mar 1, 2024

Great work!

Copy link

@mkhraisha mkhraisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work

@mprorock
Copy link

mprorock commented Mar 3, 2024

@OR13 can we get this merged today?

charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
@henkbirkholz henkbirkholz self-requested a review March 4, 2024 13:30
Copy link
Contributor

@henkbirkholz henkbirkholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now an awesome charter (I just ironed out a few nits).

🚢 it

@OR13 OR13 merged commit 7a0a635 into main Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants