Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create scorecard.yml #2

Merged
merged 1 commit into from
May 4, 2023
Merged

Create scorecard.yml #2

merged 1 commit into from
May 4, 2023

Conversation

AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented May 3, 2023

No description provided.

@AlCutter AlCutter requested a review from phbnf May 3, 2023 15:23
@phbnf
Copy link

phbnf commented May 3, 2023

All the other scorecard configs of our repos are called "scorecardS.yml", consistency on this sounds like a good idea?

@AlCutter
Copy link
Collaborator Author

AlCutter commented May 4, 2023

All the other scorecard configs of our repos are called "scorecardS.yml", consistency on this sounds like a good idea?

Sure, although this file was created automatically with the button on the workflow, so perhaps that changed at some point.

Either way, I'll update the other repos since scorecard.yml now seems to be the "recommended" name for the file.

@AlCutter
Copy link
Collaborator Author

AlCutter commented May 4, 2023

All the other scorecard configs of our repos are called "scorecardS.yml", consistency on this sounds like a good idea?

Sure, although this file was created automatically with the button on the workflow, so perhaps that changed at some point.

Either way, I'll update the other repos since scorecard.yml now seems to be the "recommended" name for the file.

Ah, yes - even the content of the autogenerated file has switched from referencing "Scorecards" to "Scorecard" at some point between my creating the configs in Trillian etc. and here.

@roger2hk
Copy link
Contributor

roger2hk commented May 4, 2023

The workflow file in scorecard repo is named as scorecard-analysis.yml.

https://github.com/ossf/scorecard/blob/main/.github/workflows/scorecard-analysis.yml

@AlCutter
Copy link
Collaborator Author

AlCutter commented May 4, 2023

The workflow file in scorecard repo is named as scorecard-analysis.yml.

https://github.com/ossf/scorecard/blob/main/.github/workflows/scorecard-analysis.yml

Hehe, it's not consistent with what the autogen tool creates either :)
I don't think it really matters a huge deal, but having them called the same thing across all of our repos seems reasonable.

@AlCutter
Copy link
Collaborator Author

AlCutter commented May 4, 2023

@phbnf
Copy link

phbnf commented May 4, 2023

+1 to what Al said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants