-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for v1.3.0 release #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please also pull in my doc fix PR before release.
@philpennock will do! I have some other changes coming to address ongoing macOS sadness, fwiw. |
and include fixes/changes from said shfmt & shellcheck versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally fix the copyright claim before commit, but approved as-is anyway.
gimme
Outdated
GIMME_COPYRIGHT="Copyright (c) 2016 Dan Buch, Tianon Gravi, Travis CI GmbH" | ||
GIMME_LICENSE_URL="https://raw.githubusercontent.com/travis-ci/gimme/v1.2.0/LICENSE" | ||
GIMME_VERSION="v1.3.0" | ||
GIMME_COPYRIGHT="Copyright (c) 2018 Dan Buch, Tianon Gravi, Travis CI GmbH" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
gimme
Outdated
@@ -398,7 +398,7 @@ _list_versions() { | |||
} | |||
|
|||
_list_known() { | |||
local exp="go([[:alnum:]\.]*)\.src.*" # :alnum: catches beta versions too | |||
local exp="go([[:alnum:]\\.]*)\\.src.*" # :alnum: catches beta versions too |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
No description provided.