Skip to content

Commit

Permalink
Use brighter green color for passing badge
Browse files Browse the repository at this point in the history 
This is the same color used for the best scores on Code Climate and
Coveralls and is more pleasing to the eye than the current
yellowy-green.
  • Loading branch information
@sferik
sferik committed Feb 28, 2013
1 parent 7384011 commit 5372e34
Showing 1 changed file with 0 additions and 0 deletions.
Binary file modified public/images/result/passing.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

7 comments on commit 5372e34

@olivierlacan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onion skin that diff and swipe back and forth, you'd kill a thousand designers with that kerning. 😉

@sferik
Copy link
Contributor Author

@sferik sferik commented on 5372e34 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 Okay. I guess I need to find better software for converting an SVG to a PNG.

@laserlemon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @olivierlacan that the text needs work. I like the color. The font is different as well, but I assume that's intended.

@olivierlacan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the font swap is intended, it should still be Open Sans.

@joshk
Copy link
Contributor

@joshk joshk commented on 5372e34 Feb 28, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sferik
Copy link
Contributor Author

@sferik sferik commented on 5372e34 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshk I'm working on a fix now at Waza. Should have a fix as soon as librsvg (and dependencies) finishes downloading over Heroku’s WiFi. Could be a few hours. 😛 If you need to deploy before then, you should revert.

@sferik
Copy link
Contributor Author

@sferik sferik commented on 5372e34 Feb 28, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cf6c605.

Please sign in to comment.