-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade default Python from 3.6 on Trusty to 3.8 on Xenial #1743
Conversation
@BanzaiMan @MariadeAnton Can anyone please help me to understand the failure message? Now that we are running on xenial, I believe that we need to do the equivalent of: addons:
apt:
sources:
- docker-xenial
packages:
- docker https://docs.travis-ci.com/user/reference/xenial/#third-party-apt-repositories-removed I can apt_packages: ['docker'], but setting apt sources eludes me. @native-api |
514f87e
to
df4d070
Compare
I believe And I really don't see why this PR attempts to add it. |
By "I don't see why", I meant because Docker is completely irrelevant to Python's default version thus to this PR's topic. |
Our only failing test is Travis::Build::Script::Python behaves like a bash script full docker container execution runs and passes. Do you believe this is not a useful test? |
Docker tests are run in |
0a2d72d
to
8bd7035
Compare
Thanks @native-api Where would I fix that test given that Trusty is EOL? |
813e96f
to
57b1719
Compare
A continuation of #1678 now that dist: xenial is the Travis CI default we can upgrade from Python 3.6 to 3.7 as the default Python on Travis CI Linux jobs.
Python 3.7 has a slightly stricter syntax than 3.6 because async and await are keywords in Python >= 3.7. For projects that use Travis CI with the default Python, this pull request will allow them to find these issues before their users do.
NOTE: This pull request currently comments out one test which is run on the Trusty-based
travisci/ci-garnet
container because Python 3.7 does not run on Trusty. Please let me know if this is acceptable or provide guidance on how to run that test on Xenial or later.