Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade default Python from 3.6 on Trusty to 3.8 on Xenial #1743

Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 15, 2019

A continuation of #1678 now that dist: xenial is the Travis CI default we can upgrade from Python 3.6 to 3.7 as the default Python on Travis CI Linux jobs.

Python 3.7 has a slightly stricter syntax than 3.6 because async and await are keywords in Python >= 3.7. For projects that use Travis CI with the default Python, this pull request will allow them to find these issues before their users do.

NOTE: This pull request currently comments out one test which is run on the Trusty-based travisci/ci-garnetcontainer because Python 3.7 does not run on Trusty. Please let me know if this is acceptable or provide guidance on how to run that test on Xenial or later.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 31, 2019

@BanzaiMan @MariadeAnton Can anyone please help me to understand the failure message?
https://travis-ci.org/travis-ci/travis-build/jobs/558975609#L746

Now that we are running on xenial, I believe that we need to do the equivalent of:

addons:
  apt:
    sources:
      - docker-xenial
    packages:
      - docker

https://docs.travis-ci.com/user/reference/xenial/#third-party-apt-repositories-removed

I can apt_packages: ['docker'], but setting apt sources eludes me. @native-api

@cclauss cclauss force-pushed the upgrade-default-Python-to-3.7 branch from 514f87e to df4d070 Compare July 31, 2019 09:34
@native-api
Copy link
Contributor

I believe docker is preinstalled, no need to install anything.
https://docs.travis-ci.com/user/docker/
https://travis-ci.org/native-api/test_travis/builds/565893910

And I really don't see why this PR attempts to add it.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 31, 2019

@native-api
Copy link
Contributor

By "I don't see why", I meant because Docker is completely irrelevant to Python's default version thus to this PR's topic.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 31, 2019

Our only failing test is Travis::Build::Script::Python behaves like a bash script full docker container execution runs and passes. Do you believe this is not a useful test?

@native-api
Copy link
Contributor

native-api commented Jul 31, 2019

@cclauss cclauss force-pushed the upgrade-default-Python-to-3.7 branch from 0a2d72d to 8bd7035 Compare July 31, 2019 13:14
@cclauss cclauss changed the title With 170 days left until Python 2 EOL, it is time to upgrade default Python Upgrade default Python from 3.6 to 3.7 on Xenial Jul 31, 2019
@cclauss cclauss changed the title Upgrade default Python from 3.6 to 3.7 on Xenial Upgrade default Python from 3.6 on Trusty to 3.7 on Xenial Jul 31, 2019
@cclauss
Copy link
Contributor Author

cclauss commented Sep 27, 2019

Docker tests are run in travisci/ci-garnet container which is Trusty-based. And 3.7 is not available for Trusty.

Thanks @native-api Where would I fix that test given that Trusty is EOL?

@cclauss cclauss changed the title Upgrade default Python from 3.6 on Trusty to 3.7 on Xenial Upgrade default Python from 3.6 on Trusty to 3.8 on Xenial Oct 22, 2019
@cclauss cclauss force-pushed the upgrade-default-Python-to-3.7 branch from 813e96f to 57b1719 Compare October 22, 2019 16:28
@cclauss cclauss closed this Oct 22, 2019
@cclauss cclauss deleted the upgrade-default-Python-to-3.7 branch October 22, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants