Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang v1.10 is parsed as 1.1 #9247

Closed
nezorflame opened this issue Feb 20, 2018 · 8 comments
Closed

Golang v1.10 is parsed as 1.1 #9247

nezorflame opened this issue Feb 20, 2018 · 8 comments

Comments

@nezorflame
Copy link

nezorflame commented Feb 20, 2018

What happened

Adding Go version 1.10 to the .travis.yml is counted as 1.1.

.travis.yml

language: go
go:
        - 1.7
        - 1.8
        - 1.9
        - 1.10
        - tip
install:
        - go get -d -v ./...
        - go get -d -v golang.org/x/tools/cmd/cover
        - go get golang.org/x/time/rate
script:
- go test -v -cover ./...

Build results

Builds

default

Log for #3.4:

...
$ gimme version
v1.3.0
$ go version
go version go1.1 linux/amd64
go.env
$ go env
GOARCH="amd64"
GOBIN=""
GOCHAR="6"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/travis/gopath"
GORACE=""
GOROOT="/home/travis/.gimme/versions/go1.1.src"
GOTOOLDIR="/home/travis/.gimme/versions/go1.1.src/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-g -O2 -fPIC -m64 -pthread"
CGO_ENABLED="1"
...

How to fix

Versions have to be wrapped in brackets in order for Travis to parse them correctly:

language: go
go:
        - "1.7"
        - "1.8"
        - "1.9"
        - "1.10"
        - "tip"
...
@BanzaiMan
Copy link
Contributor

https://docs.travis-ci.com/user/languages/go now explicitly states:

Note that, in order to choose Go 1.10, you must use go: "1.10" (a string), not go: 1.10 (a float). Using a float results in the use of Go 1.1.

I'll keep this open for now, so that other users can find it easily.

@rphillips
Copy link

FWIW, I tried "1.10.x" to specify any point release and it didn't work.

@BanzaiMan
Copy link
Contributor

@rphillips Do you have a build log URL that shows it didn’t work for you?

@rphillips
Copy link

@BanzaiMan
Copy link
Contributor

BanzaiMan commented Feb 21, 2018

That build is 5 days old. The fix for "1.10.x" was deployed a few hours ago. Please restart it, or push a new commit.

@rphillips
Copy link

will do. thanks

abrander added a commit to gansoi/gansoi that referenced this issue Feb 22, 2018
agnivade added a commit to agnivade/funnel that referenced this issue Feb 24, 2018
rfjakob added a commit to rfjakob/gocryptfs that referenced this issue Feb 27, 2018
"1.10" does not work as expected because it
is parsed as a floating point number:
travis-ci/travis-ci#9247

Added benefit is that we always get the latest point
release.
filler pushed a commit to filler/rack that referenced this issue Feb 28, 2018
Allows local builds in golang 1.10 on OS X to work.  Done as part of
needing a new spin for new OS X version (10.13).

This also wraps the version marker in the Travis CI yaml per a known
bug (travis-ci/travis-ci#9247) where the
version marker was being trapped as 1.1.
alessio added a commit to tendermint/clearchain that referenced this issue Mar 1, 2018
lithammer pushed a commit to lithammer/shortuuid that referenced this issue Mar 2, 2018
pwaller referenced this issue in go-gl/mathgl Mar 9, 2018
fluffle added a commit to fluffle/sp0rkle that referenced this issue Mar 11, 2018
Civil pushed a commit to go-graphite/carbonapi that referenced this issue Mar 15, 2018
jstemmer added a commit to jstemmer/go-junit-report that referenced this issue Mar 17, 2018
See travis-ci/travis-ci#9247.

Also add a ".x" suffix to each version so that Travis selects the latest
minor release.
jstemmer added a commit to jstemmer/go-junit-report that referenced this issue Mar 17, 2018
- Fix building for go1.10, see travis-ci/travis-ci#9247.
- Add a ".x" suffix to each version so that Travis selects the latest
  minor release.
- Remove go1.1, which is not available anymore on Travis.
jjeffery added a commit to jjeffery/apigatewayproxy that referenced this issue Mar 19, 2018
Without quotes Travis CI is parsing 1.10 as 1.1.

See issue travis-ci/travis-ci#9247
@BanzaiMan
Copy link
Contributor

@xyproto Yes, they are. Are you having problems related to this issue?

mitch000001 added a commit to mitch000001/go-hbci that referenced this issue Mar 26, 2018
As documented in https://docs.travis-ci.com/user/languages/go and
mentioned in travis-ci/travis-ci#9247 the
version for go 1.10 has to be quoted in order to be parsed correct.
lucymhdavies added a commit to skybet/cali that referenced this issue Mar 30, 2018
gabriel-vasile added a commit to gabriel-vasile/mimetype that referenced this issue Jul 2, 2018
masomel added a commit to coniks-sys/coniks-go that referenced this issue Jul 15, 2018
navytux added a commit to navytux/og-rek that referenced this issue Jul 17, 2018
"1.10" is put into quotes because otherwise Travis parses that as 1.1 -
see e.g. travis-ci/travis-ci#9247.
kisielk pushed a commit to kisielk/og-rek that referenced this issue Jul 17, 2018
"1.10" is put into quotes because otherwise Travis parses that as 1.1 -
see e.g. travis-ci/travis-ci#9247.
cheyang added a commit to kubeflow/arena that referenced this issue Jul 31, 2018
Signed-off-by: cheyang <cheyang@163.com>
cheyang added a commit to kubeflow/arena that referenced this issue Jul 31, 2018
Signed-off-by: cheyang <cheyang@163.com>

fix travis issue:travis-ci/travis-ci#9247

Signed-off-by: cheyang <cheyang@163.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 14, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 14, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 14, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 14, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 14, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 14, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 14, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 14, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 15, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 15, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 15, 2018
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.

See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to mdhorn/clr-installer that referenced this issue Aug 15, 2018
Fix version of Golang for Travis
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.
See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.
- Telemetry not starting due to systemd issues
- Disabled Telemetry testing under this is resolved

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
mdhorn added a commit to clearlinux/clr-installer that referenced this issue Aug 15, 2018
Fix version of Golang for Travis
Setting to 1.10 get parsed as a float and interrupted as 1.1 instead
of 1.10. Adding quotes so it is treated as string.
See: travis-ci/travis-ci#9247

Revamp to use a Clear Linux Docker image for build and test.
- Telemetry not starting due to systemd issues
- Disabled Telemetry testing under this is resolved

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
nicerobot added a commit to gomatic/renderizer that referenced this issue Sep 1, 2018
arinto added a commit to arinto/gojenkins that referenced this issue Sep 15, 2018
falzm pushed a commit to exoscale/zlocker that referenced this issue Sep 24, 2018
@travis-ci travis-ci locked as resolved and limited conversation to collaborators Oct 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants