Fix validto computed property infinite calls problem #2941
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscription/v2-plan in DB has valid_to null, the /plan page make infinite calls to v_subscriptions and causing the page unresponsive.
The computed property is causing infinite calls because it depends on subscription.validTo, and within the computation, it makes a call to fetchV2Subscriptions.perform(), which likely modifies subscription.validTo. This causes the computed property to re-evaluate, leading to an infinite loop.
Fixed Approach with an Observer:
Ensure fetchV2Subscriptions doesn't modify subscription.validTo directly within the computed property, as this triggers recomputation.
Use computed properties for deriving state, and use observer to avoid side effect like fetching data.