Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Pry to Development Dependency #227

Closed
wireframe opened this issue Sep 5, 2014 · 10 comments
Closed

Change Pry to Development Dependency #227

wireframe opened this issue Sep 5, 2014 · 10 comments

Comments

@wireframe
Copy link

Please move pry to a development dependency and loosen requirement to allow versions 0.10 and above.

@rkh
Copy link
Contributor

rkh commented Sep 6, 2014

I think this is wrong. Pry is used by the console command and not a development dependency.

@rkh
Copy link
Contributor

rkh commented Sep 6, 2014

We could try to make pry an optional dependency, though. What was the issue you were running into?

@wireframe
Copy link
Author

The issue I had was the Version of pry required by the Travis gem prevents upgrading several other gems in my project. 

If you need to keep it as a runtime dependency could you loosen the version requirement to allow 0.10 and above?

Sent from Mailbox

On Sat, Sep 6, 2014 at 6:38 AM, Konstantin Haase notifications@github.com
wrote:

We could try to make pry an optional dependency, though. What was the issue you were running into?

Reply to this email directly or view it on GitHub:
#227 (comment)

@BanzaiMan
Copy link
Contributor

We still support 1.8.x at the moment, which is admittedly dubious. This is the reason to keep pry on 0.9.x right now.

@rkh
Copy link
Contributor

rkh commented Sep 6, 2014

We might want to consider dropping 1.8 support in travis 1.8.x.

On Sat, Sep 6, 2014 at 6:44 PM, Hiro Asari notifications@github.com wrote:

We still support 1.8.x at the moment, which is admittedly dubious. This is
the reason to keep pry on 0.9.x right now.


Reply to this email directly or view it on GitHub
#227 (comment).

@BanzaiMan
Copy link
Contributor

👍 for dropping 1.8.x support with travis 1.8.0.

@eherot
Copy link
Contributor

eherot commented Sep 19, 2014

SERIOUS 👍 for dropping 1.8 support. Guys, that version has been deprecated for more than a year.

For those who want to use Pry today, this is a handy workaround:
$ pry _0.9.12.6_

@bobbrez
Copy link

bobbrez commented Sep 19, 2014

Good workaround @eherot but +1 on dropping 1.8 like its hot.

@jeffbyrnes
Copy link

👍 on dropping 1.8 support.

@bootstraponline
Copy link

👍 drop 1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants