Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Typhoeus requirement #756

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Drop Typhoeus requirement #756

merged 2 commits into from
Sep 21, 2020

Conversation

BanzaiMan
Copy link
Contributor

@BanzaiMan BanzaiMan commented Jun 10, 2020

It is used if available, but use Net::HTTP if it is not.

Resolves #727, #324

@BanzaiMan
Copy link
Contributor Author

$ travis login --adapter typhoeus
`--adapter typhoeus` is given, but it is not installed. Run `gem install typhoeus` and try again
$ gem install typhoeus
Fetching typhoeus-1.4.0.gem
Successfully installed typhoeus-1.4.0
1 gem installed
$ travis login --adapter typhoeus
We need your GitHub login to identify you.
This information will not be sent to Travis CI, only to api.github.com.
The password will not be displayed.

Try running with --github-token or --auto if you don't want to enter your password anyway.

Username: ^C
$

It is used if available, but use Net::HTTP if it is not.
For Ruby < 2.5 compatibility
@BanzaiMan BanzaiMan force-pushed the ha-typhoeus-optional branch from 1236a56 to 295dd54 Compare June 15, 2020 15:22
BanzaiMan added a commit that referenced this pull request Aug 7, 2020
@BanzaiMan
Copy link
Contributor Author

@BanzaiMan BanzaiMan merged commit f764d8c into master Sep 21, 2020
@BanzaiMan BanzaiMan deleted the ha-typhoeus-optional branch September 21, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Typhoeus requirement
1 participant