-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support location in bq operator #1767
Conversation
@yoyama can you review this PR? |
digdag-standards/src/main/java/io/digdag/standards/operator/gcp/BaseBqJobOperator.java
Outdated
Show resolved
Hide resolved
digdag-standards/src/main/java/io/digdag/standards/operator/gcp/BqClient.java
Outdated
Show resolved
Hide resolved
@tkawachi Thank you for your contribution. |
Thank you for your review, @yoyama. |
@tkawachi Thank you for your fix. |
@yoyama I wrote tests for load and extract. It assumes that GCS_TEST_BUCKET_ASIA is in asia-northeast1, not asia (BigQuery can't be located in asia). Where can I check the test result of CircleCI? |
@tkawachi I pushed your PR to digdag repo to run CircleCI.
|
@tkawachi I add a minor comment. Could you confirm it ? |
@tkawachi I have an another ask. Could you update the doc on the new parameters ? |
I updated the docs. I didn't change bq_ddl.md since it already mentions about location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you for your contribution!
Hello @tkawachi Thank you for your great PR and contribution to digdag! We would like to deliver some TD/Digdag swag to you as a token of our appreciation. |
Set Job location for non-US location.
Fixes #1088